[14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report #3343

SirTakobi · 2023-05-30T13:02:31Z

@TonyMasciI per capire le modifiche fatte in #3169, non ho trovato altro modo che provare in prima persona la migrazione.
Manca ancora:

pulire storia dei commit
verificare risultati report HTML/PDF
report XLSX
test automatici
rebase nel caso di modifiche in 12.0
rename (vedi anche Renamed l10n_it_account_balance_report OpenUpgrade#4094)

TonyMasciI · 2023-05-30T13:58:43Z

@TonyMasciI per capire le modifiche fatte in #3169, non ho trovato altro modo che provare in prima persona la migrazione. Manca ancora:
* [ ]  pulire storia dei commit

* [ ]  verificare risultati report HTML/PDF

* [ ]  report XLSX

* [ ]  test automatici

* [ ]  rebase nel caso di modifiche in `12.0`

Vogliamo brasare l'altra PR e lasciare questa?

SirTakobi · 2023-05-30T14:09:17Z

Vogliamo brasare l'altra PR e lasciare questa?

Lascerei aperta la tua finché non so se posso portare a termine questa.
cc @eLBati

Currently translated at 66.4% (85 of 128 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_balance_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_balance_report/it/

Currently translated at 92.2% (118 of 128 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_balance_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_balance_report/it/

Currently translated at 92.9% (119 of 128 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_balance_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_balance_report/it/

Currently translated at 95.3% (122 of 128 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_balance_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_balance_report/it/

Usando il modulo l10n_it_account_balance_report, il cron di Pulizia dati interni diventa molto lento e in alcuni casi va in blocco. L'autovacuum della tabella report_trial_balance diventa molto lenta per via delle cascade presenti nel modulo. Inserendo gli indici nei campi collegati il problema si risolve, come già realizzato nel repo OCA/account-financial-reporting#750.

Currently translated at 93.7% (121 of 129 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_balance_report Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_balance_report/it/

SirTakobi · 2023-06-27T11:27:23Z

@TonyMasciI ho avuto modo di andare avanti, direi che puoi chiudere la tua e, se vuoi, fammi sapere cosa ne pensi di questa.

@francesco-ooops @elvise grazie del supporto per lo sviluppo (ho aggiunto Ooops nei contributors).

Magari anche qualcuno dei revisori di #3169 è interessato? @GSLabIt @andreampiovesana @stefano-ooops

cc @eLBati

francesco-ooops · 2023-06-29T13:07:09Z

@TonyMasciI mentre facciamo la review funzionale puoi dare un'occhiata?

francesco-ooops · 2023-07-03T16:50:38Z

@andreampiovesana puoi fare review? grazie!

SirTakobi · 2023-07-13T15:50:16Z

Vedi anche #3064 (comment)

Alla fine ho dovuto fare il renaming 😄

Non ho usato il meccanismo di OpenUpgrade (https://oca.github.io/OpenUpgrade/use_cases/module_renaming.html) perché credo dia problemi con la versione enterprise, ho chiesto lumi in https://discord.com/channels/737652535149592587/766180676373446657/1129044284906164224.

@OCA/local-italy-maintainers si potrebbe segnare in #1905 che il modulo ha cambiato nome, che ne dite?

UPDATE: dopo https://github.com/OCA/l10n-italy/compare/c62e6014c50094fa8b7e3338c798b7a579f98d06..6de9e6abf3ad3b3b2decbf292b467b030e5919bf dovrebbe supportare sia Enterprise (dove va installato manualmente il nuovo modulo) che OpenUpgrade (dove il modulo risulterà installato automaticamente)

eLBati · 2023-07-14T05:02:46Z

@OCA/local-italy-maintainers si potrebbe segnare in #1905 che il modulo ha cambiato nome, che ne dite?

Fatto

MiquelRForgeFlow · 2023-07-14T08:58:31Z

l10n_it_financial_statements_report/__manifest__.py

    ],
+    "external_dependencies": {
+        "python": [
+            "openupgradelib",


This is not needed AFAIK, right @pedrobaeza ? I mean, it's just for migrations scripts, not for proper module code.

I added this because it is used in pre_init_hook.

Here I am trying to support both the migration flows that I described yesterday in https://discord.com/channels/737652535149592587/766180676373446657/1129044284906164224.

That is why the migration happens both in pre_init_hook and in migrations folder.
Maybe I am a bit confused on how migrations work, I would very much appreciate your points of view.

cc @sergiocorato

By the way, big thanks for having a look!

MiquelRForgeFlow · 2023-07-14T09:01:37Z

l10n_it_financial_statements_report/hooks.py

+
+
+def migrate_old_module(cr):
+    remove_models(


no need, odoo does it automatically.

When this method is executed in the pre_init_hook, without this change I have WARNING messages like:

odoo.addons.base.models.ir_model: The model account_balance_report_account could not be dropped because it did not exist in the registry.

Ok, sorry, I understand that some things have to be done different when you are calling migrations scripts in a pre-init-hook. That's something unusual so I am not sure which differences encompass this approach. Feel free!

Lines are now hidden by super when the balance is 0, so we don't need any more overrides that do that. hierarchy_on -> show_hierarchy string_types now is str XLSX class variables cannot be assigned because not in __slots__ ir.actions.report fields renames Propagate wizard and report data to report model for printing; in super all this is done directly in the wizard. The reports model name must be report.<module_name> and action/views must adapt. Adapt report and code to different report data structure. Adapt report to new HTML structure. account.account.account_balance_report_section: selection attribute will be ignored as the field is related Hack super's JS for report action to use our actions Use HTML Report instead of client action Remove inactive Maintainer New translations format Update italian translations Improved coverage

Balance is too generic, Financial statements is what this module is producing

stefano-ooops

testato ok

francesco-ooops · 2023-07-25T13:26:44Z

@TonyMasciI @andreampiovesana che ne dite?

eLBati

Tested

francesco-ooops · 2023-07-26T14:42:00Z

@primes2h a livello di terminologia può andare?

andreampiovesana

LGTM

OCA-git-bot · 2023-07-28T08:42:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

eLBati · 2023-07-28T11:55:20Z

/ocabot merge nobump

OCA-git-bot · 2023-07-28T11:55:27Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3343-by-eLBati-bump-nobump, awaiting test results.

OCA-git-bot · 2023-07-28T12:28:47Z

Congratulations, your PR was merged at efd6632. Thanks a lot for contributing to OCA. ❤️

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch from 57f522b to 39a34f6 Compare May 30, 2023 13:14

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch 2 times, most recently from 3708dbc to 4ace700 Compare June 23, 2023 14:35

SilvioGregorini and others added 15 commits June 23, 2023 17:36

[12.0] New module l10n_it_account_balance_report

e5275c0

merge PR 1264 1717 1728 1737 1739

ee7d522

FIX license compatibility

8d70b09

[UPD] account_balance_report: use numerical values in .xlsx reports

c3025e5

[FIX] l10n_it_account_balance_report: Consider previous years' earnings

6fa332d

Reformatted after template update

4b3f1e9

Manually fix manifest website key

1c96679

[IMP] l10n_it_account_balance_report: Allow to hide accounts codes

d959ed9

[IMP] l10n_it_account_balance_report: pre-commit execution

eb5f378

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch 3 times, most recently from ade1a2f to 4a0a1db Compare June 27, 2023 10:55

SirTakobi marked this pull request as ready for review June 27, 2023 11:21

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch from 4a0a1db to c9530ba Compare June 27, 2023 11:30

SirTakobi mentioned this pull request Jun 27, 2023

[14.0] mig l10n_it_account_balance_report #3169

Closed

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch from c9530ba to 0056968 Compare June 27, 2023 11:36

eLBati mentioned this pull request Jul 14, 2023

Migration to version 14.0 #1905

Open

76 tasks

SirTakobi mentioned this pull request Jul 14, 2023

Renamed l10n_it_account_balance_report OCA/OpenUpgrade#4094

Merged

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch from c62e601 to 6de9e6a Compare July 14, 2023 08:54

MiquelRForgeFlow reviewed Jul 14, 2023

View reviewed changes

eLBati changed the title ~~[MIG] l10n_it_account_balance_report~~ [14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report Jul 20, 2023

SirTakobi marked this pull request as draft July 20, 2023 14:09

SirTakobi added 2 commits July 24, 2023 11:20

[REF] l10n_it_account_balance_report: Rename

1194fb2

Balance is too generic, Financial statements is what this module is producing

SirTakobi force-pushed the 14.0-mig-l10n_it_account_balance_report branch from 6de9e6a to 1194fb2 Compare July 24, 2023 09:34

SirTakobi marked this pull request as ready for review July 24, 2023 09:58

stefano-ooops approved these changes Jul 25, 2023

View reviewed changes

eLBati approved these changes Jul 25, 2023

View reviewed changes

andreampiovesana approved these changes Jul 28, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jul 28, 2023

OCA-git-bot added the bot is merging ⏳ label Jul 28, 2023

OCA-git-bot merged commit 15925ce into OCA:14.0 Jul 28, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 28, 2023

SirAionTech mentioned this pull request Oct 2, 2023

[16.0] [MIG] l10n_it_asset_management #3271

Closed

francesco-ooops mentioned this pull request Dec 22, 2023

Nascondere i codici dei conti nella Stampa Bilancio Contabile #3199

Closed

2 tasks

francesco-ooops added the migration label Jan 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report #3343

[14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report #3343

SirTakobi commented May 30, 2023 •

edited

Loading

TonyMasciI commented May 30, 2023

SirTakobi commented May 30, 2023

SirTakobi commented Jun 27, 2023

francesco-ooops commented Jun 29, 2023

francesco-ooops commented Jul 3, 2023

SirTakobi commented Jul 13, 2023 •

edited

Loading

eLBati commented Jul 14, 2023

MiquelRForgeFlow Jul 14, 2023

pedrobaeza Jul 14, 2023

SirTakobi Jul 14, 2023

SirTakobi Jul 14, 2023

MiquelRForgeFlow Jul 14, 2023

SirTakobi Jul 14, 2023

MiquelRForgeFlow Jul 14, 2023

stefano-ooops left a comment

francesco-ooops commented Jul 25, 2023

eLBati left a comment

francesco-ooops commented Jul 26, 2023

andreampiovesana left a comment

OCA-git-bot commented Jul 28, 2023

eLBati commented Jul 28, 2023

OCA-git-bot commented Jul 28, 2023

OCA-git-bot commented Jul 28, 2023

[14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report #3343

[14.0] [MIG] l10n_it_account_balance_report > l10n_it_financial_statements_report #3343

Conversation

SirTakobi commented May 30, 2023 • edited Loading

TonyMasciI commented May 30, 2023

SirTakobi commented May 30, 2023

SirTakobi commented Jun 27, 2023

francesco-ooops commented Jun 29, 2023

francesco-ooops commented Jul 3, 2023

SirTakobi commented Jul 13, 2023 • edited Loading

eLBati commented Jul 14, 2023

MiquelRForgeFlow Jul 14, 2023

Choose a reason for hiding this comment

pedrobaeza Jul 14, 2023

Choose a reason for hiding this comment

SirTakobi Jul 14, 2023

Choose a reason for hiding this comment

SirTakobi Jul 14, 2023

Choose a reason for hiding this comment

MiquelRForgeFlow Jul 14, 2023

Choose a reason for hiding this comment

SirTakobi Jul 14, 2023

Choose a reason for hiding this comment

MiquelRForgeFlow Jul 14, 2023

Choose a reason for hiding this comment

stefano-ooops left a comment

Choose a reason for hiding this comment

francesco-ooops commented Jul 25, 2023

eLBati left a comment

Choose a reason for hiding this comment

francesco-ooops commented Jul 26, 2023

andreampiovesana left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 28, 2023

eLBati commented Jul 28, 2023

OCA-git-bot commented Jul 28, 2023

OCA-git-bot commented Jul 28, 2023

SirTakobi commented May 30, 2023 •

edited

Loading

SirTakobi commented Jul 13, 2023 •

edited

Loading