Migration l10n_ro_account_edi_ubl to 17.0 #1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dhongu, |
Refactored code for readability and consistency, including formatting and string updates. Added a new dependency (`l10n_ro_config`) in the manifest to improve modularity. Adjusted XML template with priority for overriding and streamlined mocked responses in tests.
Deleted obsolete files and code related to ANAF synchronization and UI assets. Improved error handling and logging for ANAF API responses, ensuring better tracking of unauthorized access and message refresh. Updated dependency and manifest files to reflect changes, including cleanup of unused imports and commented-out sections.
Revised `InvoiceTypeCode` from `380` to `389` and `PaymentMeansCode` values to reflect correct codes in XML test files. These changes ensure consistency and alignment with the updated validation rules for the Romanian localization module.
# Conflicts: # l10n_ro_payment_to_statement/tests/test_payment.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.