Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] Update pre-commit #3850

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[IMP] Update pre-commit #3850

merged 1 commit into from
Dec 16, 2024
+42 −16

Conversation

EmilioPascual
Copy link
Contributor

@EmilioPascual EmilioPascual commented Dec 13, 2024 •
edited
Loading

@pedrobaeza
Copy link
Member

Esto debería ser Update copier template, pero además veo una versión en el copier que no es definitiva, por lo que no serviría.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 13, 2024
@yajo
Copy link
Member

yajo commented Dec 13, 2024

Tranquilo, sí sirve. Copier lo puede gestionar bien.

@pedrobaeza
Copy link
Member

No, pero yo prefiero que esté la versión de la plantilla publicada definitivamente.

@yajo
Copy link
Member

yajo commented Dec 16, 2024

OK pues ya la he publicado. Porfa @EmilioPascual repite el proceso y actualiza el pr

@pedrobaeza
Copy link
Member

pedrobaeza commented Dec 16, 2024 •
edited
Loading

Cambiad el mensaje de commit. [BUILD] no es una etiqueta válida. Debería ser [IMP].

@EmilioPascual EmilioPascual changed the title [BUILD] Update pre-commit [IMP] Update pre-commit Dec 16, 2024
@yajo
Copy link
Member

yajo commented Dec 16, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @yajo you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza
pedrobaeza approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3850-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cb374ff. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit cb374ff into OCA:16.0 Dec 16, 2024
7 checks passed
@EmilioPascual EmilioPascual deleted the 16.0-update_pre-commit branch January 8, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilioPascual @pedrobaeza @yajo @OCA-git-bot