Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_th_account_tax_multi #401

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Oct 9, 2023

Sorry, something went wrong.

@Saran440 Saran440 force-pushed the 16.0-mig-l10n_th_account_tax_multi branch from 82ab5cb to 6366381 Compare October 10, 2023 03:21
@supichayat
Copy link

From functional test about multi deducted Withholding Tax
please following test step below,

  1. Create Vendor Bill with multi percentage of withholding tax each line and Confirm
  2. Register Payment
  3. Select Payment Difference in Mark invoice as fully paid (multi deduct) and Create Payment
  4. create WHT Certification
  5. In column Base Amount, there is none value found.

System suppose to send base amount value from vendor bill to withholding moves.

@Saran440 Saran440 force-pushed the 16.0-mig-l10n_th_account_tax_multi branch from 8d4965b to 9a22e41 Compare October 16, 2023 10:20
@Saran440 Saran440 marked this pull request as ready for review October 16, 2023 10:20
@Saran440
Copy link
Member Author

/ocabot migration l10n_th_account_tax_multi

@Saran440 Saran440 changed the title [WIP][16.0][MIG] l10n_th_account_tax_multi [16.0][MIG] l10n_th_account_tax_multi Oct 16, 2023
@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 16, 2023
20 tasks
@Saran440
Copy link
Member Author

@supichayat Thank you for your review. I fixed it please recheck.

@supichayat
Copy link

From Functional test about multi deduction WHT and Included VAT, please following test step below.

  1. create Vendor Bill with 2 lines as below
    1.1 Unit price 1,000 THB + Input VAT 7% (Included) + WHT PND3 1%
    1.2 Unit price 1,000 THB + Input VAT 7% (Included) + WHT PND3 5%
    unknown_094
  2. register payment, wizard will be shown up.
    unknown_095
  3. then create payment, an error occurred as attached.
    unknown_096

@Saran440
Copy link
Member Author

@supichayat please recheck. it error because Deduction Amount is field Monetary (support digit from currency) But other function calculate with wht amount is not rounding

I fixed it in module l10n_th_account_tax -> 0a4d2af by rounding wht amount 2 digits.
It will rounding by line
Selection_009

@Saran440 Saran440 force-pushed the 16.0-mig-l10n_th_account_tax_multi branch from 0b56cf2 to 568cdec Compare December 6, 2023 08:10
@kittiu
Copy link
Member

kittiu commented Mar 26, 2024

@Saran440 can this merged?

@kittiu kittiu force-pushed the 16.0-mig-l10n_th_account_tax_multi branch from 568cdec to 2b80db3 Compare March 26, 2024 03:02
@Saran440
Copy link
Member Author

@kittiu yes, this PR ready to merge.

@Saran440
Copy link
Member Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-401-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9937d89 into OCA:16.0 Mar 28, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 46eddea. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants