Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Pylint tests for Beta|Stable|Mature on development_status #602

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

operezavina
Copy link

Update pylint tests

  • Using the manifest file and development_status key

Values on manifest file

  • development_status: "Alpha|Beta|Production/Stable|Mature"

@max3903
Copy link
Member

max3903 commented Jan 7, 2020

@sbidoul @pedrobaeza Any interest to get this one fixed and merged?

@pedrobaeza
Copy link
Member

I think it can be interesting, but not sure with new pre-commit in 13.0 if this can work as is. @sbidoul can tell better than me.

@sbidoul
Copy link
Member

sbidoul commented Jan 7, 2020

Personally I'm not convinced lowering the quality bar for Alpha modules would facilitate contributions. Much less for Beta (which is the default level IIRC).

The errors raised by pylint-odoo are easy to fix most of the time, and many of them are non blocking.

IMO we don't need more low quality modules in OCA, we need more maintainers for medium and high quality modules.

So I'm rather -1 on this PR.

@pedrobaeza regarding pre-commit such thig is feasible (e.g. if we want to raise the bar for Mature modules) by creating a custom OCA pre-commit hook that selects the right .pylinrc file depending on development status.

@pedrobaeza
Copy link
Member

I was not talking about lowering quality checks indeed! I was talking about showing as errors some beta messages that now are only shown as warnings.

@sbidoul
Copy link
Member

sbidoul commented Jan 7, 2020

Ah, I might have misunderstood the PR then, sorry if this is the case.

@pedrobaeza
Copy link
Member

Being honest, I'm not sure either what is the goal of the PR... Reading the code I see that possibility, but maybe it's another thing.

@max3903
Copy link
Member

max3903 commented Jan 7, 2020

This PR is mostly about separating the tests based on the 3 (or 4) maturity levels.

I am fine with increasing the tests on beta modules, as far as it is lower than stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants