Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Allow to set a custom icon #465

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

ivantodorovich
Copy link
Contributor

oca-gen-addon-icon

  • Allows to use a custom icon with --src-icon option.

@GSLabIt
Copy link

GSLabIt commented Mar 18, 2021

@ivantodorovich src_path could be an url?

@ivantodorovich
Copy link
Contributor Author

@ivantodorovich src_path could be an url?

Hi @GSLabIt !

It has to be a local path. It could definitely be improved to accept urls, but some extra code would be required to identify them and to download the remote image.

However this PR didn't get much attention :) I'm using this in our processes though

@pedrobaeza
Copy link
Member

See #491 as well

@ivantodorovich
Copy link
Contributor Author

See #491 as well

That is indeed a very cool PR, but with a different purpose.

This one is to be used by non-OCA CI tools to add a default module icon to your company modules:
image

By allowing to set a custom icon, you can use this very same tool in your company repositories, using another icon like:
image

It's of no use for the OCA, but it's usefull for people using this tool in other repositories

@GSLabIt
Copy link

GSLabIt commented Mar 19, 2021

See #491 as well

That is indeed a very cool PR, but with a different purpose.

This one is to be used by non-OCA CI tools to add a default module icon to your company modules:
image

By allowing to set a custom icon, you can use this very same tool in your company repositories, using another icon like:
image

It's of no use for the OCA, but it's usefull for people using this tool in other repositories

any hint on how to use in oct-bot? @pedrobaeza

@pedrobaeza
Copy link
Member

To use what?

@GSLabIt
Copy link

GSLabIt commented Mar 19, 2021

To use what?

--src-icon to use a different icon on oca-bot? i think it can be passed as extra param, but not sure path to pass in order to make it work properly 😬

@pedrobaeza
Copy link
Member

On OCA bot, there's no sense to use another icon except OCA one.

@pedrobaeza pedrobaeza merged commit 7343658 into OCA:master Mar 19, 2021
@GSLabIt
Copy link

GSLabIt commented Mar 19, 2021

On OCA bot, there's no sense to use another icon except OCA one.

i agree, just asking because we deployed oca-bot our company. Thx anyway.

@pedrobaeza
Copy link
Member

Then propose a PR in such project for customizing that part.

@GSLabIt
Copy link

GSLabIt commented Mar 19, 2021

Then propose a PR in such project for customizing that part.

I'll try, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants