-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Allow to set a custom icon #465
Conversation
74b4952
to
e6b35aa
Compare
@ivantodorovich src_path could be an url? |
Hi @GSLabIt ! It has to be a local path. It could definitely be improved to accept urls, but some extra code would be required to identify them and to download the remote image. However this PR didn't get much attention :) I'm using this in our processes though |
See #491 as well |
That is indeed a very cool PR, but with a different purpose. This one is to be used by non-OCA CI tools to add a default module icon to your company modules: By allowing to set a custom icon, you can use this very same tool in your company repositories, using another icon like: It's of no use for the OCA, but it's usefull for people using this tool in other repositories |
any hint on how to use in oct-bot? @pedrobaeza |
To use what? |
|
On OCA bot, there's no sense to use another icon except OCA one. |
i agree, just asking because we deployed oca-bot our company. Thx anyway. |
Then propose a PR in such project for customizing that part. |
I'll try, thx |
oca-gen-addon-icon
--src-icon
option.