Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] maintenance_timesheet: Migration to 17.0 #418

Merged
merged 25 commits into from
Aug 29, 2024
Merged

[17.0][MIG] maintenance_timesheet: Migration to 17.0 #418

merged 25 commits into from
Aug 29, 2024

Conversation

FernandoRomera
Copy link

No description provided.

dalonsod and others added 24 commits August 8, 2024 09:36
@dalonsod @FernandoRomera
[ADD] maintenance_timesheet
edb7a8f
@dalonsod @FernandoRomera
[IMP] maintenance_timesheet: black, isort
763b7b9
@dalonsod @FernandoRomera
[MIG] maintenance_timesheet: Migration to 13.0
335c844 
[UPD] Update maintenance_timesheet.pot

pre-commit update

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-13.0/maintenance-13.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_timesheet/
@dalonsod @FernandoRomera
[IMP] maintenance_timesheet: add report support for requests
5aa2a05 
[UPD] Update maintenance_timesheet.pot

[UPD] README.rst

maintenance_timesheet 13.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-13.0/maintenance-13.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_timesheet/
@dalonsod @FernandoRomera
[MIG] maintenance_timesheet: Migration to 14.0
e4bc93d 
[UPD] Update maintenance_timesheet.pot

[UPD] README.rst
@mymage @FernandoRomera
Added translation using Weblate (Italian)
84faab1
@mymage @FernandoRomera
Translated using Weblate (Italian)
096f45a 
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/it/
@victoralmau @FernandoRomera
[IMP] maintenance_timesheet: Add timesheet page from maintenance requ…
856bd52 
…est form view.

TT40881

[UPD] Update maintenance_timesheet.pot

maintenance_timesheet 14.0.2.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/
@mymage @FernandoRomera
Translated using Weblate (Italian)
8e89dee 
Currently translated at 100.0% (25 of 25 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/it/

[UPD] Update maintenance_timesheet.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-14.0/maintenance-14.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_timesheet/
@victoralmau @FernandoRomera
[MIG] maintenance_timesheet: Migration to 15.0
ad6186b 
TT41113
@FernandoRomera
[UPD] Update maintenance_timesheet.pot
41e04a4
@OCA-git-bot @FernandoRomera
[UPD] README.rst
f6efbe5
@mymage @FernandoRomera
Translated using Weblate (Italian)
77ced4a 
Currently translated at 100.0% (25 of 25 strings)

Translation: maintenance-15.0/maintenance-15.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_timesheet/it/
@Ivorra78 @FernandoRomera
Translated using Weblate (Spanish)
b964cb6 
Currently translated at 100.0% (25 of 25 strings)

Translation: maintenance-15.0/maintenance-15.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_timesheet/es/
@Christian-RB @FernandoRomera
[IMP] maintenance_timesheet: pre-commit stuff
6fa7428
@Christian-RB @FernandoRomera
[MIG] maintenance_timesheet: Migration to 16.0
2d1de40
@FernandoRomera
[UPD] Update maintenance_timesheet.pot
8229a2e
@weblate @FernandoRomera
Update translation files
1fe044d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/
@Ivorra78 @FernandoRomera
Translated using Weblate (Spanish)
efae997 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/es/
@mymage @FernandoRomera
Translated using Weblate (Italian)
ab61c40 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/it/
@IT-Ideas @FernandoRomera
[IMP] maintenance_timesheet: use create_multi in account.analytic.line
cb71dd8
@OCA-git-bot @FernandoRomera
[BOT] post-merge updates
c8d284c
@mymage @FernandoRomera
Translated using Weblate (Italian)
03cadae 
Currently translated at 100.0% (22 of 22 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_timesheet
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_timesheet/it/
@FernandoRomera
[IMP] maintenance_timesheet: pre-commit auto fixes
4ecc96d
@FernandoRomera FernandoRomera mentioned this pull request Aug 8, 2024
Open
17 tasks
@dalonsod
Copy link
Contributor

dalonsod commented Aug 8, 2024

Hello, this PR actually depends on #401 , you can temporary add a test-requirements.txt file linking to it.

@FernandoRomera
Copy link
Author

FernandoRomera commented Aug 8, 2024 •
edited
Loading

@dalonsod
Thank you very much for the suggestion, but the problem lies in that in version 17 they have removed the cron to generate maintenance requests and replaced it with activities.
That's why tests fail in #401.
In #414 we add cron to module.

@dalonsod
Copy link
Contributor

dalonsod commented Aug 8, 2024

Yes, I know it and it's a todo task for #401 , not sure but it only might affect to tests. Anyway, if test-requirements.txt is added to this PR, it could help to runboat successful load and then, enable testing on it, if I'm not wrong.

@pedrobaeza
Copy link
Member

Please check https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

@dalonsod
Copy link
Contributor

@FernandoRomera could you make a rebase? maintenance_project is already available

@FernandoRomera
Copy link
Author

@dalonsod
Done.

dalonsod
dalonsod suggested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review, see minor changes requested. And please check tests improvement needed

maintenance_timesheet/__manifest__.py Outdated Show resolved Hide resolved
maintenance_timesheet/views/maintenance_request_views.xml Outdated Show resolved Hide resolved
@SapphireHotS
Copy link

Pressing on the "Hours" button I get Caused by: Error: "account.analytic.line"."is_timer_running" field is undefined.

@FernandoRomera
Copy link
Author

Pressing on the "Hours" button I get Caused by: Error: "account.analytic.line"."is_timer_running" field is undefined.

I can not reproduce it on runbot.

AntoniRomera
AntoniRomera approved these changes Aug 29, 2024
View reviewed changes
Copy link

@AntoniRomera AntoniRomera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MRomeera
MRomeera approved these changes Aug 29, 2024
View reviewed changes
Copy link

@MRomeera MRomeera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SapphireHotS
Copy link

Pressing on the "Hours" button I get Caused by: Error: "account.analytic.line"."is_timer_running" field is undefined.

I can not reproduce it on runbot.

Maybe because I'm using enterprise?

pedrobaeza
pedrobaeza approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-418-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fa6cd5e into OCA:17.0 Aug 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dee55f0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@AntoniRomera AntoniRomera AntoniRomera approved these changes

@MRomeera MRomeera MRomeera approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.