Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] base_maintenance: Fine-tuning of the form view #444

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

carlos-lopez-tecnativa
Copy link

With this commit odoo/odoo@3bd8410 the maintenance request form view now has an independent page. This commit adapts the view to align with the new page structure.

Before
image

After
image

@Tecnativa @pedrobaeza @victoralmau could you please review this

after this commit odoo/odoo@3bd8410 the maintenance request form view now has an independent page. This commit adapts the view to align with the new page structure.
@pedrobaeza pedrobaeza added this to the 17.0 milestone Jan 14, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should change the name, but instead, adapt the modules using that name as selector.

@carlos-lopez-tecnativa
Copy link
Author

carlos-lopez-tecnativa commented Jan 14, 2025

I don't think we should change the name, but instead, adapt the modules using that name as selector.

In the form view, the new page only includes a string attribute and lacks a name attribute. This is why I added the name attribute to the page. Please let me know if I missed anything.

https://github.com/odoo/odoo/blob/17.0/addons/maintenance/views/maintenance_views.xml#L137

@pedrobaeza
Copy link
Member

OK

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-444-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d9f28c. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit d962cf1 into OCA:17.0 Jan 15, 2025
6 checks passed
@pedrobaeza pedrobaeza deleted the 17.0-fix-view-base_maintenance branch January 15, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants