Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] github pre-commit action: pin python version to 3.11 #214

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[FIX] github pre-commit action: pin python version to 3.11 #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49cfcc7
[FIX] github pre-commit action: pin python version to 3.11
em230418 Oct 27, 2023
df2f469
[FIX] github pre-commit action: pin python version to 3.11 in repository
em230418 Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v2
with:
python-version: "3.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one shouldn't be pinpointed. The problem is in pre-commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one shouldn't be pinpointed. The problem is in pre-commit.

I think otherwise. Github action should not behave differently when suddenly other python version is used.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem pinpointing this is that when GitHub removes this version in the future, we will have a red CI, and meanwhile lots of version have passed, and we lost the opportunity to improve during it. It's not a big deal though, as this is only the CI for this repo, and the effort to change it is not too much.

The template is other beast, as it propagates to each OCA repo, but pinpointing is right now the only option (or wait till pre-commit fixes whatever problem it is), and maybe we will need to raise any library version as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we must pin the python version for pre-commit, just like we pin it for running tests.
Otherwise we hit this kind of issue every time GitHub upgrades its default python.

My suggestion would be to use the same python version as for the tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you want to say here. Can you do a suggestion if still on time?

- uses: pre-commit/[email protected]
3 changes: 3 additions & 0 deletions src/.github/workflows/pre-commit.yml.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:
{%- elif odoo_version < 14 %}
with:
python-version: "3.8"
{%- else %}
with:
python-version: "3.11"
{%- endif %}
- name: Get python version
run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
Expand Down
Loading