Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codecov): continue on error #253

Closed
wants to merge 1 commit into from

Conversation

yajo
Copy link
Member

@yajo yajo commented May 2, 2024

This should help in the future to protect against situations like #250, when Codecov suddenly changes something, starts to fail and becomes blocking for everybody here.

This should help in the future to protect against situations like OCA#250, when Codecov suddenly changes something, starts to fail and becomes blocking for everybody here.
@yajo yajo mentioned this pull request May 2, 2024
@sbidoul
Copy link
Member

sbidoul commented May 2, 2024

I think that would not have helped in the current situation because the codecov step does not fail, it just blocks.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.

@yajo
Copy link
Member Author

yajo commented May 2, 2024

OK, but it would help in case codecov server goes down, for example. That'd be mostly as dramatic as #250.

Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@github-actions github-actions bot closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants