Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 15/16/17: Removed first line break on pre-commit template #256

Merged
merged 1 commit into from
May 13, 2024

Conversation

manuel-florido
Copy link
Contributor

Hello,

When using v15/v16/v17, It creates .pre-commit-config.yaml with a line break on the first line.

If you use pre-commit It fails at the first attempt because this line gets removed.

With this change, the file is created correctly

Thank you!

When using v15/v16/v17, It creates .pre-commit-config.yaml with a line break on the first line.
If you use pre-commit It fails at the first attempt because this line gets removed
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@OCA-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yajo yajo merged commit b47dbcc into OCA:master May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants