-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] consider unsafe fixes for UP008 as safe #288
Conversation
{%- if odoo_version >= 11.0 %} | ||
extend-safe-fixes = ["UP008"] | ||
{%- endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{%- if odoo_version >= 11.0 %} | |
extend-safe-fixes = ["UP008"] | |
{%- endif %} | |
extend-safe-fixes = ["UP008"] |
Since we don't support Odoo 10 anymore, and ruff does not support python 2 anyway no need for this version test.
Do we know if ruff UP008 preserves exoctic uses of super that we have in Odoo? Things like |
Hello @sbidoul, yes it does. As long as the second argument is NOT equivalent to the first argument of the enclosing method, due to this method For example, it does not impact this case
|
Great. Let me know when you have updated the PR to remove the version test. |
4db2ac3
to
5f44303
Compare
This PR has the |
Context
This change