[IMP] Ask user input if the target branch already exists #60
Conversation
| @@ -98,53 +99,70 @@ def __init__( | |||
| # get migration scripts, depending to the migration list | |||
| self._get_migration_scripts() | |||
|
|
|||
| def _execute_shell(self, shell_command, **kwargs): | |||
There was a problem hiding this comment.
I don’t really see the advantage in this patch to the method… IMHO, it ends up complicating a bit the different methods and the overall structure… I would leave it as is, passing the pass keyword argument each time…
There was a problem hiding this comment.
@ivantodorovich what is your point of view, regarding that comment ?
thanks !
There was a problem hiding this comment.
It's to avoid having to pass the directory_path every time (and to avoid issues in case we forget about it)
For example, see the issue we had here: #64
As when running migrations, we mostly want to execute the shell in the directory of the repository (provided by the --directory argument)
ivantodorovich
force-pushed
the
imp-existing-branch
branch
from
5df4944
to
bf6e041
Compare
ivantodorovich
force-pushed
the
imp-existing-branch
branch
from
bf6e041
to
1091c5d
Compare
|
Hi. I recently added pre-commit file, so a lot of files changed. A simple rebase should be done. |
No description provided.