Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15.0 mig partner contact department #1322

Closed
wants to merge 35 commits into from
Closed

15.0 mig partner contact department #1322

wants to merge 35 commits into from

Conversation

Galoperd
Copy link
Contributor

No description provided.

yajo and others added 30 commits August 17, 2022 18:19
@yajo @Galoperd
Rename to partner_contact_department.
fb0aa48
@feketemihai @Galoperd
Add ondelete option to parent_id, runbot fails to lack of attribute.
79ef6cc
@cubells @Galoperd
partner_contact_department
a28a67e 
    * Add tests
    * Other minor changes
@oca-transbot @Galoperd
OCA Transbot updated translations from Transifex
6d5f26f
@chienandalu @Galoperd
partner_contact_department: Migration to 10.0
8af436e
@pedrobaeza @Galoperd
partner_department: Depend on sales_team
e7c1be4 
As it uses some XML-IDs from it.
@oca-transbot @Galoperd
OCA Transbot updated translations from Transifex
0be6bf5
@oca-travis @Galoperd
Update partner_contact_department.pot
293d3a0
@Galoperd
Translated using Weblate (Português (Brasil))
7c66925 
Currently translated at 100,0% (16 of 16 strings)

Translation: partner-contact-10.0/partner-contact-10.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-10-0/partner-contact-10-0-partner_contact_department/pt_BR/
@MiquelRForgeFlow @Galoperd
partner_contact_department: Migration to 11.0
9cc03ce
@Nikul-Chaudhary @Galoperd
[MIG] partner_contact_department v11 to v12
33e29ef
@OCA-git-bot @Galoperd
[UPD] README.rst
46f0dee
@oca-travis @Galoperd
[UPD] Update partner_contact_department.pot
3760c8c
@oca-transbot @Galoperd
Update translation files
a01b6e6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/
@OCA-git-bot @Galoperd
[UPD] README.rst
24dcee3
@Galoperd
Translated using Weblate (Portuguese (Brazil))
5b2c7a1 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/pt_BR/
@Galoperd
Translated using Weblate (Spanish)
c6bbc34 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/es/
@pedrocs-exo @Galoperd
Translated using Weblate (Portuguese)
53f4791 
Currently translated at 100.0% (15 of 15 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_contact_department/pt/
@HaraldPanten @Galoperd
[IMP] partner_contact_department: black, isort, prettier
bd7e759
@HaraldPanten @Galoperd
[MIG]partner_contact_department: Migration to 13.0
443701f
@HaraldPanten @Galoperd
[IMP] partner_contact_department: black, isort, prettier
e7a3dcf
@oca-travis @Galoperd
[UPD] Update partner_contact_department.pot
b6f0a8c
@OCA-git-bot @Galoperd
[UPD] README.rst
9c3ea79
@oca-transbot @Galoperd
Update translation files
a24f9c6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: partner-contact-13.0/partner-contact-13.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_contact_department/
@newtratip @Galoperd
[MIG] partner_contact_department: Migration to 14.0
0e43a91
@oca-travis @Galoperd
[UPD] Update partner_contact_department.pot
2e7c404
@OCA-git-bot @Galoperd
partner_contact_department 14.0.1.0.1
c20635b
@primes2h @Galoperd
Translated using Weblate (Italian)
380004f 
Currently translated at 78.5% (11 of 14 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_department
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_department/it/
@OCA-git-bot @Galoperd
[IMP] update dotfiles [ci skip]
c09616f
@Galoperd
[IMP] partner_contact_department: black, isort, prettier
15e313d
@Galoperd Galoperd mentioned this pull request Aug 22, 2022
Open
68 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration contact_partner_department

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 22, 2022
rousseldenis
rousseldenis reviewed Aug 22, 2022
View reviewed changes
partner_contact_department/models/res_partner.py Outdated
department_id = fields.Many2one("res.partner.department", "Department")


class ResPartnerDepartment(models.Model):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this model in separate file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis done

Copy link
Contributor Author

@Galoperd Galoperd Aug 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note there is a mistake with your module naming: /ocabot migration contact_partner_department
it should be /ocabot migration partner_contact_department, so there is a dupplicated entry at migration list

@rousseldenis please kindly check, thank you !

@rousseldenis
Copy link
Contributor

/ocabot migration partner_contact_department

@OCA-git-bot
Copy link
Contributor

The migration issue (#1153) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1318.
Perhaps you should check that there is no duplicate work.
CC : @Galoperd

@Galoperd
Copy link
Contributor Author

@rousseldenis many thanks for solving this. No duplicate work existing so this PR#1322 is ready for review and merge.

rousseldenis
rousseldenis approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@andres-pcg
Copy link

@rousseldenis is there any reason why runboat/build is still pending? I believe that's the only thing that's missing to have this merged.

Regards,

@Galoperd
Copy link
Contributor Author

@rousseldenis not sure why runboat/build was not auto processed… is there something wrong in the code or do I need to do something else ? thanks

@rousseldenis
Copy link
Contributor

@rousseldenis not sure why runboat/build was not auto processed… is there something wrong in the code or do I need to do something else ? thanks

I think runboat was sick at that time.

Could you try to rebase?

@andres-pcg
Copy link

@Galoperd Thanks for the follow-up. Tests are now failing 😥

@Galoperd Galoperd closed this Oct 30, 2022
@Galoperd Galoperd deleted the 15.0-mig-partner_contact_department branch October 30, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.