[18.0] [MIG] partner_contact_birthplace: Migration to 18.0 #1903
Conversation
Currently translated at 100.0% (4 of 4 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_birthplace Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_birthplace/it/
Currently translated at 100.0% (7 of 7 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_birthplace Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_birthplace/ca/
Currently translated at 100.0% (7 of 7 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_birthplace Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_birthplace/es/
Currently translated at 100.0% (7 of 7 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_contact_birthplace Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_contact_birthplace/it/
| @@ -1 +1,2 @@ | |||
| odoo_test_helper | |||
| odoo-addon-partner_contact_personal_information_page @ git+https://github.com/OCA/partner-contact.git@refs/pull/1900/head#subdirectory=partner_contact_personal_information_page | |||
There was a problem hiding this comment.
I'm curious about this directive. from what I understand it allows the test to be green by taking into account an unmerged dependency. Do you remove this commit before merging or the bot take care of it ?
There was a problem hiding this comment.
I must remove this commit before merging
There was a problem hiding this comment.
@houssine78 The process is described here: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29
Indeed, this is used in order to:
- show tests are passing
- be able to test the PR functionally with runboat.
|
/ocabot migration partner_contact_birthplace |
| /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//group[@name='personal_information_group']"> | ||
| <field name="birth_city" /> |
There was a problem hiding this comment.
I'm wondering why this order?
Shouldn't it country first, then state and city ?
There was a problem hiding this comment.
I probably copied the same order that is used in the partner address https://github.com/odoo/odoo/blob/29405bb41516a57b635c1b8cedbfa564d626b964/odoo/addons/base/views/res_partner_views.xml#L138-L141, but it can be changed indeed if you prefer another order.
Migration from 17.0 to 18.0
Issue: #1856