-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] pos_loyalty_exclude #1217
base: 16.0
Are you sure you want to change the base?
Conversation
rule.product_ids | ||
or rule.product_category_id | ||
or rule.product_tag_id | ||
or rule.product_domain not in ("[]", "[['sale_ok', '=', True]]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is [['sale_ok', '=', True]] intended or do you meant [('sale_ok', '=', True)]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Ricardoalso, it is intended as it is in https://github.com/odoo/odoo/blob/def7c93c6c05e1814d6221cf90e93bdd8867e473/addons/pos_loyalty/models/loyalty_rule.py#L29
This PR has the |
rule.valid_product_ids = self.env["product.product"].search( | ||
[("loyalty_exclude", "=", False)] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rule.valid_product_ids = self.env["product.product"].search( | |
[("loyalty_exclude", "=", False)] | |
) | |
rule.valid_product_ids = self.env["product.product"].search( | |
[("loyalty_exclude", "=", False), ("available_in_pos", "=", True)], order="id" | |
) |
3140a53
to
8039559
Compare
No description provided.