Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_bypass_global_discount #1220

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Jul 10, 2024

Note

  • This module is meant to be installed as a companion to sale_global_discount. It makes sure the POS will also honors the bypass_global_discount field when user inputs a Discount at the Order level.

@cyrilmanuel
Copy link

adding description on the PR :

This module is meant to be installed as a companion to sale_global_discount. It makes sure the POS will also honors the bypass_global_discount field when user inputs a Discount at the Order level.


def _loader_params_product_product(self):
params = super()._loader_params_product_product()
params["search_params"]["fields"].append("bypass_global_discount")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
params["search_params"]["fields"].append("bypass_global_discount")
if "search_params" in params and "fields" in params["search_params"]:
params["search_params"]["fields"].append("bypass_global_discount")

@trisdoan trisdoan force-pushed the 16.0-add-pos_bypass_global_discount branch from 9b919a5 to 6d09939 Compare July 16, 2024 02:14
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants