[16.0][MIG] product_variant_sale_price #281

RabbitJon-S73 · 2023-02-01T10:48:34Z

Standard migration to 16.0.

Added #280

RabbitJon-S73 · 2023-02-23T12:04:16Z

@Kev-Roche there is any issue with the pre-commit in v16.0? It works in my local

Kev-Roche · 2023-02-23T19:41:37Z

@RabbitJon-S73 I m not the right person for this kind of question sorry ;)

RabbitJon-S73 · 2023-03-03T07:08:56Z

@sergio-teruel could you review?

BT-anieto

Thanks for your work! Some changes to be done, since there are some changes to do in the migration which have not been applied. Check out the migration page Check https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

On the other hand remember to squash the commits as indicted in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

BT-anieto · 2023-03-16T12:56:22Z

product_variant_sale_price/models/product_product.py

+            if self.env.context.get("uom"):
+                context_uom = uom_model.browse(self.env.context.get("uom"))
+                price = product.uom_id._compute_price(price, context_uom)


Why change? We should minimise the code changes in a migration and the code was proper?

#280 I took this changes, I think is the correct behaviour

Great! Thank you very much. Let me check.

By the way, tests are not passing. I will rereview when they pass.

Hey, I solved the problem with the test. I also saw your review on #280 and I changed the .get after being once checked

Thx @RabbitJon-S73. I asked a question in #280 because I was a bit surprised about the change. Still not an answer, but the code looks good to me :)

product_variant_sale_price/models/product_product.py

product_variant_sale_price/tests/test_product_product.py

BT-anieto

LGTM

OCA-git-bot · 2023-03-21T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

antoniocanovas

Functional review OK

ecino · 2023-04-14T06:40:13Z

Oh, I didn't see this one because it's not linked in the migration issue #272 . I did also a migration myself in which I also included some view changes that I think make sense and help better use the functionality. However here there are some changes in the uom computation part that I think are good. Would you like to review and integrate my changes as well in your PR? See #290

ecino · 2023-04-14T06:47:25Z

I went ahead and integrated your corrections into my PR (by cherry-picking and rebasing).

hugo-cordoba · 2023-04-21T09:01:00Z

LGTM! (code review)

Apply some PEP8 cleanup Avoid redundant loop

[NEW][8.0] product_variant_sale_price: Improvements [NEW][8.0] product_variant_sale_price: Fix travis OCA Transbot updated translations from Transifex

…ate is created [product_variant_sale_price] Set minimun fix_price among variants to ensure consistency with the price shown in the shop OCA Transbot updated translations from Transifex

…ariants Steps to reproduce: - create more than one variant - change fix_price of one variant Current behavior: - lst_price of all variants are changed Expected behavior: - lst_price of only selected variant is changed

[UPD] Update product_variant_sale_price.pot [UPD] README.rst Translated using Weblate (Dutch) Currently translated at 100,0% (4 of 4 strings) Translation: product-variant-11.0/product-variant-11.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-11-0/product-variant-11-0-product_variant_sale_price/nl/ Update translation files Updated by Update PO files to match POT (msgmerge) hook in Weblate. [UPD] README.rst

[UPD] Update product_variant_sale_price.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-variant-12.0/product-variant-12.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_sale_price/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-variant-12.0/product-variant-12.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_sale_price/ Translated using Weblate (Portuguese) Currently translated at 100.0% (6 of 6 strings) Translation: product-variant-12.0/product-variant-12.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-12-0/product-variant-12-0-product_variant_sale_price/pt/

[UPD] Update product_variant_sale_price.pot [UPD] README.rst Translated using Weblate (Portuguese) Currently translated at 100.0% (6 of 6 strings) Translation: product-variant-14.0/product-variant-14.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-14-0/product-variant-14-0-product_variant_sale_price/pt/

… Python3

[UPD] Update product_variant_sale_price.pot Translated using Weblate (French) Currently translated at 83.3% (5 of 6 strings) Translation: product-variant-15.0/product-variant-15.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-15-0/product-variant-15-0-product_variant_sale_price/fr/ Translated using Weblate (Catalan) Currently translated at 100.0% (6 of 6 strings) Translation: product-variant-15.0/product-variant-15.0-product_variant_sale_price Translate-URL: https://translation.odoo-community.org/projects/product-variant-15-0/product-variant-15-0-product_variant_sale_price/ca/

hildickethan · 2023-06-16T07:47:08Z

product_variant_sale_price/models/product_product.py

+    @api.model
+    def create(self, vals):
+        product_tmpl = super().create(vals)
+        product_tmpl._update_fix_price(vals)
+        return product_tmpl


better as multi

@hildickethan-S73 Done!

ecino · 2023-06-22T11:37:48Z

@RabbitJon-S73 I thought you would close this one in favor of #290

maxgrassi · 2023-07-09T21:29:49Z

Version of studio73
Bug report: Does not manage prices at variant level.

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch from f5b7af8 to 35b61ad Compare February 3, 2023 12:39

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch from 35b61ad to 945e24d Compare February 13, 2023 07:49

RabbitJon-S73 changed the title ~~16.0 mig product variant sale price~~ [16.0][MIG] product_variant_sale_price Feb 14, 2023

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch 2 times, most recently from 0cb268f to e78431b Compare February 20, 2023 14:24

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch from e78431b to 33d2918 Compare March 1, 2023 10:23

sergio-teruel approved these changes Mar 3, 2023

View reviewed changes

BT-anieto suggested changes Mar 16, 2023

View reviewed changes

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch 7 times, most recently from 89a8a53 to a43bec5 Compare March 17, 2023 12:34

BT-anieto reviewed Mar 21, 2023

View reviewed changes

BT-anieto approved these changes Mar 21, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 21, 2023

antoniocanovas approved these changes Mar 27, 2023

View reviewed changes

ecino mentioned this pull request Apr 14, 2023

[16.0][MIG] product_variant_sale_price: Migration to 16.0 #290

Merged

hugo-cordoba approved these changes Apr 21, 2023

View reviewed changes

[ADD][8.0] product_variant_sale_price: New module

7621056

Apply some PEP8 cleanup Avoid redundant loop

sergio-teruel and others added 13 commits June 7, 2023 14:01

[NEW][8.0] product_variant_sale_price: Add test, fixes and translation

b9fbe51

[NEW][8.0] product_variant_sale_price: Improvements [NEW][8.0] product_variant_sale_price: Fix travis OCA Transbot updated translations from Transifex

[product_variant_sale_price] Also set fix_price to variant when templ…

a6bf9e2

…ate is created [product_variant_sale_price] Set minimun fix_price among variants to ensure consistency with the price shown in the shop OCA Transbot updated translations from Transifex

[IMP] product_variant_sale_price: black, isort, prettier

db43690

[MIG] product_variant_sale_price: Migration to 13.0

949966e

[IMP] product_variant_sale_price: black, isort, prettier

733cc5d

[MIG] product_variant_sale_price: Migration to 14.0

49d0a9e

[IMP] product_variant_sale_price: pylint

b63855f

[IMP] product_variant_sale_price: remove redundant super className in…

b6131a8

… Python3

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch from a43bec5 to bd500ad Compare June 7, 2023 12:02

hildickethan reviewed Jun 16, 2023

View reviewed changes

[MIG] product_variant_sale_price: Migration to 16.0

4e0a63c

RabbitJon-S73 force-pushed the 16.0-mig-product_variant_sale_price branch from bd500ad to 4e0a63c Compare June 22, 2023 11:32

RabbitJon-S73 closed this Oct 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] product_variant_sale_price #281

[16.0][MIG] product_variant_sale_price #281

RabbitJon-S73 commented Feb 1, 2023

RabbitJon-S73 commented Feb 23, 2023 •

edited

Loading

Kev-Roche commented Feb 23, 2023

RabbitJon-S73 commented Mar 3, 2023

BT-anieto left a comment

BT-anieto Mar 16, 2023

RabbitJon-S73 Mar 16, 2023

BT-anieto Mar 17, 2023

RabbitJon-S73 Mar 17, 2023

BT-anieto Mar 21, 2023

BT-anieto left a comment •

edited

Loading

OCA-git-bot commented Mar 21, 2023

antoniocanovas left a comment

ecino commented Apr 14, 2023

ecino commented Apr 14, 2023

hugo-cordoba commented Apr 21, 2023

hildickethan Jun 16, 2023

RabbitJon-S73 Jun 22, 2023

ecino commented Jun 22, 2023

maxgrassi commented Jul 9, 2023 •

edited

Loading

[16.0][MIG] product_variant_sale_price #281

[16.0][MIG] product_variant_sale_price #281

Conversation

RabbitJon-S73 commented Feb 1, 2023

RabbitJon-S73 commented Feb 23, 2023 • edited Loading

Kev-Roche commented Feb 23, 2023

RabbitJon-S73 commented Mar 3, 2023

BT-anieto left a comment

Choose a reason for hiding this comment

BT-anieto Mar 16, 2023

Choose a reason for hiding this comment

RabbitJon-S73 Mar 16, 2023

Choose a reason for hiding this comment

BT-anieto Mar 17, 2023

Choose a reason for hiding this comment

RabbitJon-S73 Mar 17, 2023

Choose a reason for hiding this comment

BT-anieto Mar 21, 2023

Choose a reason for hiding this comment

BT-anieto left a comment • edited Loading

Choose a reason for hiding this comment

OCA-git-bot commented Mar 21, 2023

antoniocanovas left a comment

Choose a reason for hiding this comment

ecino commented Apr 14, 2023

ecino commented Apr 14, 2023

hugo-cordoba commented Apr 21, 2023

hildickethan Jun 16, 2023

Choose a reason for hiding this comment

RabbitJon-S73 Jun 22, 2023

Choose a reason for hiding this comment

ecino commented Jun 22, 2023

maxgrassi commented Jul 9, 2023 • edited Loading

RabbitJon-S73 commented Feb 23, 2023 •

edited

Loading

BT-anieto left a comment •

edited

Loading

maxgrassi commented Jul 9, 2023 •

edited

Loading