Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] Module for displaying price comparisons per product variant #297

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ecino
Copy link

@ecino ecino commented Jul 13, 2023

No description provided.

@ecino ecino force-pushed the 16.0-product_variant_sale_price_compare branch from cb74d61 to e50ed14 Compare July 13, 2023 08:48
@maxgrassi
Copy link

LGTM

1 similar comment
@eantones
Copy link

LGTM

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 12, 2023
@ecino
Copy link
Author

ecino commented Nov 13, 2023

Anyone else willing to review this?

@giarve
Copy link
Contributor

giarve commented Nov 17, 2023

For the previous reviewers: If you want the bot to mark this as approved you have to click on the commit and review the changes from there. If you only write a message it is not enough, mantainers are not notified.

Also, runboat job should be restarted as it is stuck at "pending".

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 19, 2023
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@ecino
Copy link
Author

ecino commented Mar 25, 2024

Can we merge this?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024
Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@ecino
Copy link
Author

ecino commented Aug 6, 2024

Can we merge instead of closing, when everything seems ok?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 6, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be in OCA/e-commerce, and start with website_sale_, as the dependency is clear.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants