Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Conditioning Unique variant and Current selection values use FIX #315 #316

Closed
wants to merge 1 commit into from

Conversation

joelkm
Copy link

@joelkm joelkm commented Oct 31, 2023

Product Variant Configurator seems to treat the Product Variant Creation Menu as a product template record, so its data goes through the execution flow as a supposed product template without attributes (tries to use the unique variant and tries to restrict product possible values to a non-existing selection).

This contribution prevents from using unique variants and values from the selection if they don't exist. It fixes #315 "Product Variant Creation menu not showing" issue without breaking the expected functionality.

@joelkm joelkm changed the title Conditioning Unique variant and Current selection values use [FIX] Conditioning Unique variant and Current selection values use Oct 31, 2023
@joelkm joelkm changed the title [FIX] Conditioning Unique variant and Current selection values use [FIX] Conditioning Unique variant and Current selection values use FIX #315 Oct 31, 2023
@giarve
Copy link
Contributor

giarve commented Nov 3, 2023

@ChrisOForgeFlow you might be interested in this one

Copy link

github-actions bot commented Mar 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 3, 2024
@github-actions github-actions bot closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening the Product Variant creation menu from the Product Variant view throws error
2 participants