-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_variant_specific_description #351
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] product_variant_specific_description #351
Conversation
…plate description
Currently translated at 100.0% (7 of 7 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_specific_description Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_specific_description/it/
Currently translated at 100.0% (7 of 7 strings) Translation: product-variant-16.0/product-variant-16.0-product_variant_specific_description Translate-URL: https://translation.odoo-community.org/projects/product-variant-16-0/product-variant-16-0-product_variant_specific_description/es/
c762def
to
ddbd54e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there are some errors in product template view, manifest and an improvement in the tests.
<field name="inherit_id" ref="product.product_template_only_form_view" /> | ||
<field name="arch" type="xml"> | ||
<xpath expr="//field[@name='description']/.." position="attributes"> | ||
<attribute name="invisible">'product_variant_count', '>', 1</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<attribute name="invisible">'product_variant_count', '>', 1</attribute> | |
<attribute name="invisible">product_variant_count > 1</attribute> |
|
||
{ | ||
"name": "Product Variant Specific Description", | ||
"version": "17.0.1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version": "17.0.1.0.1", | |
"version": "17.0.1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SetUpClass is a better option.
ddbd54e
to
1d574d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the pandoc-3.1.13-1-amd64.deb file
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
No description provided.