Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_variant_specific_description #351

Open
wants to merge 11 commits into
base: 17.0
Choose a base branch
from

Conversation

David-Luis-Mora
Copy link

No description provided.

@David-Luis-Mora David-Luis-Mora force-pushed the 17.0-mig-product_variant_specific_description branch from c762def to ddbd54e Compare May 8, 2024 13:40
@David-Luis-Mora David-Luis-Mora mentioned this pull request May 8, 2024
6 tasks
Copy link

@MarioLM-23 MarioLM-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are some errors in product template view, manifest and an improvement in the tests.

<field name="inherit_id" ref="product.product_template_only_form_view" />
<field name="arch" type="xml">
<xpath expr="//field[@name='description']/.." position="attributes">
<attribute name="invisible">'product_variant_count', '>', 1</attribute>
Copy link

@MarioLM-23 MarioLM-23 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<attribute name="invisible">'product_variant_count', '>', 1</attribute>
<attribute name="invisible">product_variant_count &gt; 1</attribute>


{
"name": "Product Variant Specific Description",
"version": "17.0.1.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "17.0.1.0.1",
"version": "17.0.1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetUpClass is a better option.

@David-Luis-Mora David-Luis-Mora force-pushed the 17.0-mig-product_variant_specific_description branch from ddbd54e to 1d574d7 Compare May 8, 2024 15:51
Copy link
Member

@gurneyalex gurneyalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the pandoc-3.1.13-1-amd64.deb file

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants