[16.0][FIX] project_sequence: Force generate sequence_code when creating project from list view #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yajo, @anddago78, |
| @@ -72,7 +72,7 @@ def create(self, vals_list): | |||
| # It is important to set sequence_code before calling super() because | |||
| # other modules such as hr_timesheet expect the name to always have a value | |||
| for vals in vals_list: | |||
| if "sequence_code" not in vals: | |||
| if vals.get("sequence_code", False): | |||
There was a problem hiding this comment.
That's the opposite of the current behavior with no other check.
IMHO, the code should be like this:
Suggested change
| if vals.get("sequence_code", False): | |
| sequence_code = vals.get("sequence_code", False) | |
| if not sequence_code: |
As in views, sequence_code is present but with a "" value.
joscanog
force-pushed
the
16.0-fix-project_sequence
branch
3 times, most recently
from
06d3f96
to
9b61aef
Compare
rousseldenis
approved these changes
Jun 24, 2024
rousseldenis
approved these changes
Jun 24, 2024
|
@joscanog Could you squash commits that you think can be merged together? |
joscanog
force-pushed
the
16.0-fix-project_sequence
branch
from
fad0576
to
9b61aef
Compare
joscanog
force-pushed
the
16.0-fix-project_sequence
branch
from
9b61aef
to
606c5a9
Compare
Thanks @rousseldenis. I've just done the squash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a project from the list view, the sequence_code was not generated. These changes fix that problem.