-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] purchase_blanket_order #2379
[17.0][MIG] purchase_blanket_order #2379
Conversation
6deab97
to
dcafda2
Compare
"summary": "Purchase Blanket Orders", | ||
"depends": [ | ||
"purchase", | ||
"web_action_conditionable", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the module, this dependency looks like it is not needed. Can you check if it is really the case? If not, we probably can get rid of it during this migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I tested it and it looks like the module no longer needs this dependency. Removing it.
dcafda2
to
cb10dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cb10dd7
to
04c261e
Compare
The default behavior in a PO is that the purchsing UoM is used as the PO line UoM when set in the product. Blanket Orders should do the same, otherwise it is a bit confusing.
Currently translated at 100.0% (150 of 150 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/
Currently translated at 100.0% (151 of 151 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/
Currently translated at 100.0% (153 of 153 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/it/
Currently translated at 100.0% (153 of 153 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_blanket_order Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_blanket_order/es/
04c261e
to
67f1910
Compare
67f1910
to
961de26
Compare
@HviorForgeFlow solved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LoisRForgeFlow The confirmation message is generated in purchase_request module, and there is an existing pr solving this problem: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ArnauCForgeFlow I tested the wrong module 🤣
This time I reviewed blanket order, functional review is good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for attending the comments.
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at b193ea8. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration to 17.0