Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] repair_purchase_return: Migration to 16.0 #27

Merged
merged 11 commits into from
Jun 17, 2024
Merged

[16.0][MIG] repair_purchase_return: Migration to 16.0 #27

merged 11 commits into from
Jun 17, 2024

Conversation

PauBForgeFlow
Copy link

No description provided.

mariadforgeflow
mariadforgeflow approved these changes Oct 9, 2023
View reviewed changes
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-mig-repair_purchase_return branch from b94d35e to 9320e17 Compare October 30, 2023 16:17
@AaronHForgeFlow
Copy link
Contributor

Rebased to rebuild runboat, sorry

@LoisRForgeFlow
Copy link

@AaronHForgeFlow @PauBForgeFlow what is missing for this one?

@LoisRForgeFlow LoisRForgeFlow added the question Further information is requested label Mar 26, 2024
@JordiBForgeFlow JordiBForgeFlow force-pushed the 16.0-mig-repair_purchase_return branch from 9320e17 to b0487ee Compare June 17, 2024 08:33
LoisRForgeFlow
LoisRForgeFlow approved these changes Jun 17, 2024
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-27-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 17, 2024
@OCA-git-bot
Merge PR #27 into 16.0
bf3e161 
Signed-off-by LoisRForgeFlow
LoisRForgeFlow
LoisRForgeFlow reviewed Jun 17, 2024
View reviewed changes
test-requirements.txt Outdated
@@ -0,0 +1 @@
odoo-addon-purchase_return@git+https://github.com/OCA/purchase-workflow.git@refs/pull/1975/head#subdirectory=setup/purchase_return
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aborting merge, @JordiBForgeFlow could you remove this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LoisRForgeFlow Done!

@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-27-by-LoisRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@JordiBForgeFlow JordiBForgeFlow force-pushed the 16.0-mig-repair_purchase_return branch from b0487ee to 23f7602 Compare June 17, 2024 08:49
@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-27-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 696d944 into OCA:16.0 Jun 17, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5e394a4. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-mig-repair_purchase_return branch June 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@mariadforgeflow mariadforgeflow mariadforgeflow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PauBForgeFlow @AaronHForgeFlow @LoisRForgeFlow @OCA-git-bot @JordiBForgeFlow @mariadforgeflow @ChrisOForgeFlow