Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] repair_type_security #40

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[15.0][ADD] repair_type_security #40

merged 1 commit into from
Mar 8, 2024

Conversation

AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Feb 14, 2024 •
edited
Loading

Glue module so access to repair types is based on groups defined in repair_security instead of using stock goups

cc @ForgeFlow

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-repair_type_security branch 2 times, most recently from e457817 to c6330c4 Compare February 14, 2024 12:35
JordiMForgeFlow
JordiMForgeFlow approved these changes Mar 8, 2024
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM, maybe auto_install?

GuillemCForgeFlow
GuillemCForgeFlow approved these changes Mar 8, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽

@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-repair_type_security branch from c6330c4 to 5d999d7 Compare March 8, 2024 11:12
@AaronHForgeFlow
Copy link
Contributor Author

Code review LGTM, maybe auto_install?

Yes, I think it is a good point, I just did the change

LoisRForgeFlow
LoisRForgeFlow approved these changes Mar 8, 2024
View reviewed changes
Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-40-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8f7e810 into OCA:15.0 Mar 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 592c5eb. Thanks a lot for contributing to OCA. ❤️

@AaronHForgeFlow AaronHForgeFlow deleted the 15.0-repair_type_security branch March 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AaronHForgeFlow @OCA-git-bot @LoisRForgeFlow @JordiMForgeFlow @GuillemCForgeFlow