Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] repair_quality_control: New module repair_quality_control #55

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Sep 13, 2024

New module repair_quality_control
This module allows to create quality control inspections from repair order
when that one is done. One repair order is linked to many different inspections.

cc https://github.com/APSL 155857
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review

Grabacion.de.pantalla.desde.2024-09-13.16-28-21.webm

@peluko00 peluko00 force-pushed the 17.0-add-repair_quality_control branch 2 times, most recently from 5d49403 to 0647311 Compare September 13, 2024 14:19
@miquelalzanillas
Copy link
Contributor

Good work. The workflow looks perfect.

Seems there is an error while creating inspection order from button.

KeyError: '%s'

@peluko00
Copy link
Contributor Author

Good work. The workflow looks perfect.

Seems there is an error while creating inspection order from button.

KeyError: '%s'

Thanks for the feedback, fixed!

@peluko00 peluko00 force-pushed the 17.0-add-repair_quality_control branch from 0647311 to edcca54 Compare September 13, 2024 14:24
@peluko00 peluko00 force-pushed the 17.0-add-repair_quality_control branch from edcca54 to 6318a12 Compare September 13, 2024 14:26
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as intended, tested in runboat.

Copy link
Contributor

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00
Copy link
Contributor Author

peluko00 commented Oct 2, 2024

@LoisRForgeFlow can you review please

Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-55-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 26d183d into OCA:17.0 Oct 24, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e37708a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants