[15.0][FIX] repair_stock_move: proper main lot management & default location for remove operations #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When product to be repaired has tracking two different issues could be raised: * If a repair line hasn't lot filled (because e.g. product has no tracking), lot/serial for repaired product is used for lines reservation and an error is raised, due to incompatibility with the line product, when this product is untracked. * When creating stock move reservation for repaired product, move line is properly created, but sometimes stock quant is incorrectly updated, e.ge. if there's an older lot available, because the lot was not properly marked during reservation process. This commit fixes both issues
|
Overall LG |
…ve operations With this fix, for "remove" repair lines repair location is not used as default source location, that is preserved for "add" operations
dalonsod
force-pushed
the
15.0-fix-repair_stock_move-mainlot
branch
from
a300830 to
03431f6
Compare
AaronHForgeFlow
approved these changes
Sep 26, 2024
|
@LoisRForgeFlow is this ready to be merged? When done, I'll check if this should be ported to v16 as well |
There was a problem hiding this comment.
Thanks @dalonsod LGTM, just a suggestion: do you think you could add a small test case for avoiding future regressions?
|
@LoisRForgeFlow OK, I'll add some tests when possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes added with this PR:
(1) Proper main lot management:
When product to be repaired has tracking two different issues could be raised:
This commit fixes both issues and fixes #39
(2) Default repair line source location for remove operations:
With this fix, for "remove" repair lines repair location is not used as default source location, that is preserved for "add" operations.
@AaronHForgeFlow @DavidJForgeFlow could you review? If needed, I'd split this in two different PRs.