[15.0][FIX] repair_stock_move: On starting the repair do the confirmation of stock moves #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the confirmation of moves instead of direct assignment. It may happen that the stock moves are already confirmed without quantity reserved in the quant. This cause an error when trying to do the unreservation that is performed in the _action_assign. Doing the _action_confirm is safer because it does the reservation and then the assignment and in the assignment, when the reservation is made: https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_move_line.py#L388 the is no issues
If we don't do this, and the moves are confirmed without reservation, then you may end with this error:
cc @ForgeFlow