[15.0][ADD] repair_stock_move_restrict_lot: Assign lot on stock move creation. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
force-pushed
the
15.0-fix-repair_stock_move-reservation
branch
from
04875c2 to
8c18c88
Compare
AaronHForgeFlow
changed the title
|
In addition, if for some reason the correct quant is reserved but then we try to cancel the repair order you may end with this error, because the system is trying to unreserve the incorrect quant again: |
AaronHForgeFlow
force-pushed
the
15.0-fix-repair_stock_move-reservation
branch
from
8c18c88 to
c7f1136
Compare
AaronHForgeFlow
changed the title
Glue module between repair_stock_move and stock_restrict_lot. It assigns the repair lot to the stock moves on creation. Otherwise in the _action_assign it may reserve the incorrect quant and then and error is raised when unreserving the quant: https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_move_line.py#L388
AaronHForgeFlow
force-pushed
the
15.0-fix-repair_stock_move-reservation
branch
from
c7f1136 to
d161c4c
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c235b9a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new module. It is needed when using repair_stock_move and using lots. Otherwise in the_action_assign it may reserve the incorrect quant and then and error is raised when unreserving the quant: https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_move_line.py#L388
Steps to reproduce. Create a product tracked with serial number and create multiple quants for various serials. It may happen that the reservation is done in the incorrect serial. See test case added for reference
Without this module you may get this error:
cc @ForgeFlow