Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] l10n/brazil: add antoniospneto as member #28

Merged

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jul 26, 2024

Hello OCA maintainers,

@renatonlima and myself would like to promote Antonio Neto @antoniospneto from the Brazilian Engenere company as a PSC for the OCA/l10n-brazil repo.

Antonio has been doing excellent contributions over the last 3 years:
https://github.com/OCA/l10n-brazil/graphs/contributors

  • over: 364+ quality commits
  • 148+ merged PRs https://github.com/OCA/l10n-brazil/pulls?q=is%3Apr+is%3Amerged+author%3Aantoniospneto
  • countless quality reviews
  • authored a couple new modules
  • contributed PRs on other OCA repos
  • overall he helped a lot (fixed hard issues, found complex issues during reviews) with the l10n_br_fiscal module, the l10n_br_account module, the banking boleto/CNAB modules and many other modules.
  • he has a good knowledge how open source works
  • helped a lot during the v14, v15 and v16 migrations.

It is worth mentioning that OCA/l10n-brazil is simply the largest of all the OCA repos (both in term of code with over 130k lines of Python+XML and in term of commits with over 13k commits, making it weight as much as 10% of Odoo CE...) so we cannot accept anyone as a PSC even with hundred of commits as the responsibility is so huge in such a huge repo. But over the last 3 years @antoniospneto definitely reached the skills and contributions to be one more PSC of the project.

cc the 3 other PSC's: @renatonlima @marcelsavegnago @mileo
and 2 other of the current top contributors: @mbcosta @felipemotter

Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. I totally agree. Neto's collaboration has been very important for the Brazilian community.

@rvalyi
Copy link
Member Author

rvalyi commented Jul 26, 2024

also, I forgot to mention but @antoniospneto also helped a ton with the l10n_br_nfe Electronic Invoicing module, making the code a lot more cleaner and well tested.

Copy link

@vanderleiromera vanderleiromera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@etobella etobella merged commit 95c4223 into OCA:master Jul 26, 2024
1 check passed
@mileo
Copy link
Member

mileo commented Jul 26, 2024

Congratulations on the work done in recent years! It was about time! The Brazilian localization needs more contributors! May the open source spirit continue to be strong!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants