Help maintaining https://github.com/OCA/l10n-italy #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteoopenf
approved these changes
Oct 25, 2024
SirAionTech
suggested changes
Oct 29, 2024
| @@ -292,6 +293,7 @@ local-italy-maintainers: | |||
| - francesco-ooops | |||
| - SirAionTech | |||
| - MarcoCalcagni | |||
| - Borruso | |||
There was a problem hiding this comment.
Suggested change
| - Borruso |
Too many times I have asked @Borruso to:
- please squash the administrative commits
- please fix the commit message
- please add a test
- please describe the issue that is being fixed
- please fix the CI
Since the maintainers should enforce the rules, they should be the first ones to follow them.
Moreover, being @Borruso an employee of @MarcoCalcagni I don't see any added value for them in being both maintainers.
There was a problem hiding this comment.
P.S. Don't PSC members have to sign the CLA?
|
Penso che in ogni caso @Borruso possa essere d'aiuto nella manutenzione del repository e nelle attività del PSC. Per me è 👍 |
|
@Borruso se vuoi puoi riaprire la PR così magari sentiamo anche altri pareri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@OCA/local-italy-maintainers let me know what you think.