-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] graphql_base #397
Conversation
/ocabot migration graphql_base |
/ocabot migration graphql_base |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Can you preserve the commit history using the recommended procedure? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 |
@sbidoul sorry might have missed something, will check |
Currently translated at 100.0% (1 of 1 strings) Translation: rest-framework-16.0/rest-framework-16.0-graphql_base Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-graphql_base/it/
1581c5e
to
f6ee4d5
Compare
@sbidoul please check |
Ah, no, my bad, it was good already, since the branch was initialized from 16.0. |
f6ee4d5
to
d97aa0f
Compare
Please set installable=True in both manifests. |
d97aa0f
to
ecdc774
Compare
@sbidoul it's done |
ecdc774
to
08f3a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look if something could be improved, but the change looks good, and the demo works, so 👍
This PR has the |
@sbidoul we use this module a lot, will check if we can propose some improvements latter on. |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@sbidoul The merge process could not be finalized, because command
|
Hm, that's the bot build process being confused by this types.py at the addon root. I'll need to fix it in the bot. |
@sbidoul Did you had the change to look at the issue you mentioned? |
Tentative fix deployed in the bot. Let's try again. /ocabot merge nobump |
On my way to merge this fine PR! |
@sbidoul The merge process could not be finalized, because command
|
Hm, not good yet. |
/ocabot merge nobump |
@lmignon The merge process could not start, because command `git merge --no-ff -m 'Merge PR #397 into 17.0 Signed-off-by lmignon' tmp-pr-397` failed with output:
|
@dduarte-odoogap Can you rebase please? I would like to try to merge it again. |
I'll take care of this. There is a fundamental issue with this |
Superseded by #461 |
No description provided.