Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pydantic: Migration to 17.0 #437

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

trisdoan
Copy link

@trisdoan trisdoan commented Jun 5, 2024

No description provided.

@lmignon
Copy link
Contributor

lmignon commented Oct 3, 2024

Hi @trisdoan

Thank you for the migration. Can you fix the pre-commit error so I can process to the merge?

lmi

@trisdoan trisdoan marked this pull request as draft October 3, 2024 09:06
@trisdoan
Copy link
Author

trisdoan commented Oct 3, 2024

DRAFT: fix failed pre-commit

@trisdoan trisdoan marked this pull request as ready for review October 3, 2024 09:17
@trisdoan
Copy link
Author

trisdoan commented Oct 3, 2024

Hello @lmignon, all checks are passed, please help to merge it, thanks

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this migration

@lmignon
Copy link
Contributor

lmignon commented Oct 3, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-437-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8447502 into OCA:17.0 Oct 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 190ff66. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants