[16.0] [IMP] fastapi: Factorize error handling and use it in tests with raise_server_exceptions=False #464
+121
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lmignon, |
lmignon
reviewed
Oct 16, 2024
lmignon
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thank you @paradoxxxzero for this useful change. A little comment to reduce the diff and it'll be perfect.
…e_server_exceptions=False
paradoxxxzero
force-pushed
the
16.0-imp-fastapi-error-handling-in-tests
branch
from
d214043 to
ccc8c89
Compare
Done :) |
lmignon
approved these changes
Oct 16, 2024
|
ping @AnizR |
AnizR
approved these changes
Oct 16, 2024
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at c89c938. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now using
raise_server_exceptions=Falseleads to all exceptions to be returned as 500.This PR aims to share the error handling between odoo FastAPIDispatcher and the starlette TestClient to get meaningful response in tests.
This also adds a log of 500 exceptions in testing which is very useful to get unhandled exceptions traceback while running the tests.