Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP]base_rest: show first-level menu to admins only #477

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

PicchiSeba
Copy link

fw-port of #425 to 16.0

@PicchiSeba PicchiSeba marked this pull request as draft November 25, 2024 11:06
@PicchiSeba
Copy link
Author

PicchiSeba commented Nov 25, 2024

@lmignon I'm trying to investigate the broken tests but they fail even on the 16.0 branch without any of my proposed changes. Do you have any idea why?

@lmignon
Copy link
Contributor

lmignon commented Nov 25, 2024

@PicchiSeba I don't understand the problem. On my laptop all the tests succeed. I need to analyze this problem in depth.

@PicchiSeba
Copy link
Author

@lmignon I don't know what I'm doing wrong, the tests for the fastapi module consistently fail, even when the repo is at commit c89c938.

I run the tests with invoke test -m fastapi
Should I set an environment variable somewhere? Could it be a missing dependency? (I get no error for that though)

@lmignon
Copy link
Contributor

lmignon commented Nov 25, 2024

@lmignon I don't know what I'm doing wrong, the tests for the fastapi module consistently fail, even when the repo is at commit c89c938.

I run the tests with invoke test -m fastapi Should I set an environment variable somewhere? Could it be a missing dependency? (I get no error for that though)

something may have changed in Odoo and as I don't have the latest version on my machine, I can't see it. Unfortunately, I don't have the time right now to analyze the problem further.

@PicchiSeba
Copy link
Author

Understandable, thanks for the answer regardless

@PicchiSeba
Copy link
Author

PicchiSeba commented Dec 2, 2024

As stated in #470, tests were broken because of a change in upstream odoo

@giarve
Copy link

giarve commented Dec 10, 2024

I was thinking that maybe is it better to show it with developer mode enabled + admin settings?

Just a guess, but this PR still definitely improves the situation right now (shown to all, even non-technical users or normal employees).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants