Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] sale_order_partner_no_autofollow #2715

Merged

Conversation

ChristianSantamaria
Copy link
Contributor

Standard migration + fix res.config.settings parameter definition

@ChristianSantamaria ChristianSantamaria force-pushed the 15.0-mig-sale_order_partner_no_autofollow branch from 0c141d6 to f635185 Compare October 9, 2023 15:39
@ChristianSantamaria ChristianSantamaria force-pushed the 15.0-mig-sale_order_partner_no_autofollow branch from f635185 to b569ebd Compare October 10, 2023 06:42
@dalonsod
Copy link

Hello @dessanhemrayev @CetmixGitDrone could you review? This migration also includes a fix that could be ported to original v13 implementation. Thanks!

@dalonsod
Copy link

@stefan-tecnativa @barkat-matthias could you review? Thanks!

@dalonsod
Copy link

@Drsmartinkus could you review? Thanks!

@rousseldenis
Copy link
Contributor

/ocabot migration sale_order_partner_no_autofollow

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 7, 2023
"website": "https://github.com/OCA/sale-workflow",
"category": "Sale",
"depends": ["sale"],
"maintainers": ["dessanhemrayev", "CetmixGitDrone"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix are these maintainer still accurate?
Did we agree to not declare bots as maintainers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix are these maintainer still accurate? Did we agree to not declare bots as maintainers?

Yes, we have removed bots long ago so we don't maintain our modules any more. Looks like this remains from the old times. Please remove the "maintainer" section completely or put someone else there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix Okay. BTW, I still think it would be very valuable for OCA to provide so sort of mechanism to help people get notifications about changes to any addon, whether they are maintainer or not. One idea I have in that direction is OCA/oca-github-bot#265.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix Okay. BTW, I still think it would be very valuable for OCA to provide so sort of mechanism to help people get notifications about changes to any addon, whether they are maintainer or not. One idea I have in that direction is OCA/oca-github-bot#265.

@sbidoul yes, totally agree with you! I think this should be a topic for a more detailed discussion. Probably during the OCA day (still hope to get there) 😄

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test.

Compared with v13, there is one bug fix in reading the config parameter 👍

Copy link
Contributor

@dessanhemrayev dessanhemrayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Aug 13, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2715-by-sbidoul-bump-nobump, awaiting test results.

@sbidoul
Copy link
Member

sbidoul commented Aug 13, 2024

migration to 16.0 in #3271

sbidoul added a commit to acsone/sale-workflow that referenced this pull request Aug 13, 2024
@OCA-git-bot OCA-git-bot merged commit c1bb9ae into OCA:15.0 Aug 13, 2024
3 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9c631e8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants