-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] sale_order_partner_no_autofollow #2715
[15.0][MIG] sale_order_partner_no_autofollow #2715
Conversation
0c141d6
to
f635185
Compare
f635185
to
b569ebd
Compare
Hello @dessanhemrayev @CetmixGitDrone could you review? This migration also includes a fix that could be ported to original v13 implementation. Thanks! |
@stefan-tecnativa @barkat-matthias could you review? Thanks! |
@Drsmartinkus could you review? Thanks! |
/ocabot migration sale_order_partner_no_autofollow |
"website": "https://github.com/OCA/sale-workflow", | ||
"category": "Sale", | ||
"depends": ["sale"], | ||
"maintainers": ["dessanhemrayev", "CetmixGitDrone"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix are these maintainer still accurate?
Did we agree to not declare bots as maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix are these maintainer still accurate? Did we agree to not declare bots as maintainers?
Yes, we have removed bots long ago so we don't maintain our modules any more. Looks like this remains from the old times. Please remove the "maintainer" section completely or put someone else there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix Okay. BTW, I still think it would be very valuable for OCA to provide so sort of mechanism to help people get notifications about changes to any addon, whether they are maintainer or not. One idea I have in that direction is OCA/oca-github-bot#265.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix Okay. BTW, I still think it would be very valuable for OCA to provide so sort of mechanism to help people get notifications about changes to any addon, whether they are maintainer or not. One idea I have in that direction is OCA/oca-github-bot#265.
@sbidoul yes, totally agree with you! I think this should be a topic for a more detailed discussion. Probably during the OCA day (still hope to get there) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and functional test.
Compared with v13, there is one bug fix in reading the config parameter 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
migration to 16.0 in #3271 |
Congratulations, your PR was merged at 9c631e8. Thanks a lot for contributing to OCA. ❤️ |
Standard migration + fix res.config.settings parameter definition