Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][CHG] auth_oauth_autologin: redirect to the oauth in JS to keep track of the fragment #511

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[13.0][CHG] auth_oauth_autologin: redirect to the oauth in JS to keep track of the fragment #511

merged 2 commits into from
Mar 19, 2024

Conversation

benwillig
Copy link
Contributor

At the moment, if the user click on an Odoo mail notification message, he expects to be redirected on the record form view,. Using the autologin method, he will be redirected to the odoo home page instead after a successful login. This is due to the lost fragment of the original URI.
To correct this behavior, the redirect is done in javascript. Sending the original URI with its fragment to get the correct redirect URI.

Unfortunately, the login page has to be rendered first.

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@benwillig benwillig changed the title [13.0][CHG] redirect to the oauth in JS to keep track of the fragment [WIP][13.0][CHG] redirect to the oauth in JS to keep track of the fragment May 10, 2023
@benwillig benwillig force-pushed the 13.0-autologin_keep_fragment-bwi branch 4 times, most recently from 163b899 to ea8dd8e Compare May 10, 2023 14:37
@benwillig benwillig changed the title [WIP][13.0][CHG] redirect to the oauth in JS to keep track of the fragment [13.0][CHG] redirect to the oauth in JS to keep track of the fragment May 10, 2023
@benwillig benwillig force-pushed the 13.0-autologin_keep_fragment-bwi branch from ea8dd8e to 58a1997 Compare May 10, 2023 14:39
@sbidoul sbidoul changed the title [13.0][CHG] redirect to the oauth in JS to keep track of the fragment [13.0][CHG] auth_oauth_autologin: redirect to the oauth in JS to keep track of the fragment Jul 1, 2023
@sbidoul sbidoul mentioned this pull request Jul 1, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@github-actions github-actions bot closed this Dec 10, 2023
@sbidoul sbidoul reopened this Dec 11, 2023
@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sbidoul
Copy link
Member

sbidoul commented Dec 11, 2023

@benwillig can you confirm this works in production?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 17, 2023
@benwillig
Copy link
Contributor Author

@sbidoul Yes it's working in production.

@sbidoul
Copy link
Member

sbidoul commented Mar 19, 2024

Thanks!

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-511-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a1ea4c into OCA:13.0 Mar 19, 2024
7 of 8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b4a0ec. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 13.0-autologin_keep_fragment-bwi branch March 19, 2024 14:50
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@BT-jortells
Merge pull request OCA#511 from brain-tec/15.0.project_SV_559.t151701
a97e388 
[t151701] global default SAML provider
@sbidoul sbidoul mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwillig @OCA-git-bot @sbidoul