Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] auth_admin_passkey #578

Merged
merged 79 commits into from
Nov 26, 2023

Conversation

amkarthik
Copy link
Member

legalsylvain and others added 30 commits November 21, 2023 11:32
…ion if user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…s the same password as the admin user, sending a mail to admin user.
… installation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…xxx']

[REF] res_users.py : same call to self.pool in other res_users class.
[ADD] Test OCA#1 to OCA#5 to avoid regression;
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
@pedrobaeza
Copy link
Member

[IMP] auth_admin_passkey: black, isort, prettier commit contains a .deb file that shouldn't be there, and the version should be changed in the other commit. Another extra thing is that the commit message is not correct. See https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

@amkarthik amkarthik force-pushed the 17.0-mig-auth_admin_passkey branch from 6c371aa to 7d9ca96 Compare November 21, 2023 07:29
@amkarthik
Copy link
Member Author

@pedrobaeza
Done with the changes.
Thanks

@pedrobaeza
Copy link
Member

/ocabot migration auth_admin_passkey

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 21, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 21, 2023
19 tasks
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. LGTM. thanks !

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-578-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c551151 into OCA:17.0 Nov 26, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 32b0350. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.