Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] auth_saml: password reset when deactivating the config settings #599

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

leemannd
Copy link
Contributor

@leemannd leemannd commented Jan 3, 2024

issue

  • have users with password
  • install the module auth_saml
  • activate the paramter that allows to login with the password
  • setup of the user with the saml provider
  • update the settings by removing the possibility to log with the password

This will delete the ir.config parameter, but not trigger the removal of the password.

Fix
Now when we update the settings and unlink the related ir.config.parameter. We trigger the removal of passwords

Once this PR is merged, I'll forward port it to next versions

@leemannd leemannd force-pushed the 14.0-fix-auth_saml-password_reset branch 4 times, most recently from 3114fc2 to 1cff726 Compare January 3, 2024 09:46
@leemannd leemannd force-pushed the 14.0-fix-auth_saml-password_reset branch from 1cff726 to 7c2f060 Compare January 3, 2024 09:48
@leemannd
Copy link
Contributor Author

leemannd commented Jan 3, 2024

Hello @vincent-hatakeyama as you recently worked on this module, do you have time for a review and eventually a merge?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@vincent-hatakeyama
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-599-by-vincent-hatakeyama-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 79300f1 into OCA:14.0 Jan 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3209739. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants