[18.0][MIG] auth_user_case_insensitive: Migration to 18.0 #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amh-mw
suggested changes
Jan 23, 2025
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
501fad0 to
ad9d922
Compare
…f `_login` * Update code and tests to override `_login` method
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-12.0/server-auth-12.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_user_case_insensitive/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/es/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_user_case_insensitive/
|
@amh-mw Oh, my bad! Can you review this now? |
amh-mw
suggested changes
Jan 23, 2025
There was a problem hiding this comment.
Per Migration to version 18.0, I would expect two commits at the very end:
- [IMP] auth_user_case_insensitive: pre-commit auto fixes
- [MIG] auth_user_case_insensitive: Migration to 18.0
El-khamisi
force-pushed
the
18.0-mig-auth_user_case_insensitive
branch
from
0dfa869 to
13f74eb
Compare
|
@amh-mw I updated the commit history you can recheck now |
amh-mw
suggested changes
Jan 23, 2025
| if credential.get("type") and credential["type"] == "password": | ||
| credential["login"] = credential["login"].lower() | ||
|
|
||
| return super()._login(db, credential, user_agent_env) |
There was a problem hiding this comment.
Changes track with core Odoo implementation of auth_passkey 1:
Footnotes
There was a problem hiding this comment.
I don't get what you mean, can you explain more, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.