Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] sign_oca: sign_oca_pdf checkFilledAll #28

Merged
merged 1 commit into from
May 22, 2024

Conversation

PauBForgeFlow
Copy link

@PauBForgeFlow PauBForgeFlow commented Apr 11, 2024

Fix the calculation about if the required items available for the role are filled

Depends on #22

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@PauBForgeFlow PauBForgeFlow marked this pull request as draft April 11, 2024 08:15
@PauBForgeFlow PauBForgeFlow marked this pull request as ready for review May 21, 2024 06:29
Fix the way to calculate if all required items available for the role are filled
@PauBForgeFlow PauBForgeFlow force-pushed the 16.0-fix-sign_oca-sign_oca_pdf branch 3 times, most recently from b16253b to b32fcbb Compare May 22, 2024 05:48
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-28-by-etobella-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 22, 2024
Signed-off-by etobella
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-28-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0210914 into OCA:16.0 May 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b141efa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants