[ADD] survey_sign_oca: survey and sign_oca connector #99

kobros-tech · 2025-04-02T17:48:56Z

Because of the nice odoo survey interaction and organized questions and well designed format, there is a need to show the signers a survey and fill, then send them a filled sign request waiting for their approval so that we save time for them and fetch information in an interesting way not a boring one.

The commit is under development and we need to apply the idea in a professional way, and business bearing one!

description, configuration is TODO

based on PR
#91

#102

https://github.com/OCA/survey/#157

OCA-git-bot · 2025-04-02T17:49:00Z

Hi @etobella,
some modules you are maintaining are being modified, check this out!

dnplkndll · 2025-04-02T22:05:36Z

@kobros-tech I think you want to make a new module for this connector.

I think there needs to be a complete process review too. if the fields are to map from the sign to the survey should that be able to be created from the sign template?

maybe we could use the US streamlines as a demo item since it covers the most US states and would be able to then create the exemption needed for the tex service.

https://www.streamlinedsalestax.org/docs/default-source/forms/exemption-certificateb926a7ab4a0d43e1ad4fe8eb19e79cbb.pdf?sfvrsn=857843d_5

kobros-tech · 2025-04-02T23:09:50Z

@kobros-tech I think you want to make a new module for this connector.

I think there needs to be a complete process review too. if the fields are to map from the sign to the survey should that be able to be created from the sign template?

maybe we could use the US streamlines as a demo item since it covers the most US states and would be able to then create the exemption needed for the tex service.

https://www.streamlinedsalestax.org/docs/default-source/forms/exemption-certificateb926a7ab4a0d43e1ad4fe8eb19e79cbb.pdf?sfvrsn=857843d_5

now I improved the field item to be just one "Survey" and according to each one of them I compare the placehloder to the key of the answer, video is showing that.

I didn't want to give my suggestion of creating a new module untill you give me the suggetion on it.

I will try to apply other ones too.

etobella

Create a glue module. do not add the dependancy here

victoralmau

In addition to #99 (review), I believe the module could be similar to maintenance_sign_oca. Besides, it seems that what is commented in #91 (comment) will also be necessary, right?

kobros-tech · 2025-04-03T07:35:57Z

In addition to #99 (review), I believe the module could be similar to maintenance_sign_oca. Besides, it seems that what is commented in #91 (comment) will also be necessary, right?

yes, it's better to have it in a separate module, I wish I could as I have to patch some js methods.

etobella · 2025-04-03T07:37:21Z

We will check the hooks and add them if they have sense. Do not worry about that.

However, I think we shouldn't add unnecessary dependancies on the module.

kobros-tech · 2025-04-03T23:16:16Z

Now I add a standalone module to connect between sing_oca and survey.

kobros-tech · 2025-04-03T23:19:08Z

@dnplkndll

kobros-tech · 2025-04-05T00:01:54Z

If there is a signatur field in the request it will throw error, and it is handle in this PR #102 it is inside sign_oca module.

kobros-tech · 2025-04-06T06:14:35Z

kobros-tech · 2025-04-08T04:03:28Z

https://youtu.be/KaGNmiYn7ZM

victoralmau · 2025-04-16T07:08:50Z

survey_sign_oca/models/sign_oca_request.py

+class SignOcaRequest(models.Model):
+    _inherit = "sign.oca.request"
+
+    # This field is required for the inverse of maintenance.equipment.


Suggested change

# This field is required for the inverse of maintenance.equipment.

# This field is required for the inverse of survey.user.input.

victoralmau · 2025-04-16T07:10:08Z

survey_sign_oca/models/survey_invite.py

+                "default_maintenance_equipment_id": self.id,
+                "search_default_maintenance_equipment_id": self.id,


Suggested change

"default_maintenance_equipment_id": self.id,

"search_default_maintenance_equipment_id": self.id,

"default_maintenance_equipment_id": self.id,

"search_default_maintenance_equipment_id": self.id,

These fields are not the correct ones, you will have to change them for the corresponding ones.

It's a big mistake, I will fix

victoralmau · 2025-04-16T07:10:39Z

survey_sign_oca/models/survey_survey.py

+class Survey(models.Model):
+    _inherit = "survey.survey"
+
+    start_button_name = fields.Char("Survey Start Button Name", default="Start")


Why is this field necessary for sign_oca? What use case are you trying to cover? Is this really necessary in this module?

The module is extending the concept meaning of survey module, now it can take a rool for many other functions like filling the exemption data but not in the document directly, so the case is not exactly answering a survey.

So survey module can do jobs like: survey, questionaire, filling docs and maybe evenmore.

Start Survey button name is very specific, and it can be start a survey, stary a questionaire start a foo.

victoralmau · 2025-04-16T07:15:43Z

survey_sign_oca/models/sign_oca_request.py

+    def get_related_survey_answers(self):
+        self.ensure_one()
+        # get survey answers for this sign request
+        model_id = self.request_id.template_id.model_id
+        survey_participation = self.request_id.record_ref
+        survey = {}
+        if survey_participation and model_id and model_id.model == "survey.user_input":
+            for line in survey_participation.user_input_line_ids:
+                if line.question_id.question_type == "matrix":
+                    answer = line.suggested_answer_id.value
+                    survey.update({line.matrix_row_id.value: answer})
+                elif line.question_id.question_type in ["binary", "signature"]:
+                    answer = line.answer_binary_ids[:1].value_binary
+                    survey.update({line.question_id.display_name: answer})
+                else:
+                    answer = line.display_name
+                    survey.update({line.question_id.display_name: answer})
+        return survey
+
+    def fill_survey_related_items(self, vals):
+        survey = self.get_related_survey_answers()
+        items = vals["items"]
+        for key in items:
+            item = items[key]
+            placeholder = item.get("placeholder")
+            if survey.get(placeholder) and item["role_id"] == self.role_id.id:
+                if survey.get(placeholder) and item["field_type"] == "text":
+                    item["value"] = survey.get(placeholder)
+                elif survey.get(placeholder) and item["field_type"] == "check":
+                    item["value"] = SurveyUtils.format_answer(survey.get(placeholder))
+                elif survey.get(placeholder) and item["field_type"] == "signature":
+                    item["value"] = survey.get(placeholder)
+        return vals
+
+    def get_info(self, access_token=False):
+        vals = super().get_info(access_token)
+        vals = self.fill_survey_related_items(vals)
+        return vals


Can you explain what this is intended to do (adding comments in the methods explaining what they do would help).
Are you trying to fill in survey data through the signature?

yes, I will

I am just sending the same data from the server to the sign_request frontend so signers will see their answers in the corresponding field places.

victoralmau · 2025-04-16T07:16:49Z

survey_sign_oca/__manifest__.py

+    "website": "https://github.com/OCA/sign",
+    "author": "Kencove, Odoo Community Association (OCA)",
+    "license": "AGPL-3",
+    "depends": ["sign_oca", "survey", "survey_question_type_binary"],


Suggested change

"depends": ["sign_oca", "survey", "survey_question_type_binary"],

"depends": ["sign_oca", "survey", "survey_question_type_binary"],

IMP the survey_question_type_binary dependency should not be necessary.

it is important if the survey takers will give answers of type binary or multibinary or signature.

It is very important for them to sign, and I can not ignore this field as I need it, and it is available in an OCA module.

but I will try to use get method if the field is present or not, I will try no problem.

kobros-tech · 2025-04-17T13:16:26Z

@victoralmau
for the #91 (comment) commit if you are not going to merge, I really need the field_type to be shown in the form view and allow users to deal with. because if someone delete the data I introduce they can not create it again!.

kobros-tech · 2025-04-17T13:20:13Z

@etobella
@victoralmau

I removed the dependency from manifest, but still having the external ones. The one related to survey is not critical here and optional, but the one related to sign_oca is important if getting merged otherwise I show the field I want here instead.

Some handy comments are added to, changes are in a separate commit for simplicity for now.

once you agree we transition to test cases.

kobros-tech mentioned this pull request Apr 2, 2025

[16.0][IMP] sign_oca enable the user to select all the value of type char, text or m2o from the res.partner object #91

Open

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from b1607ee to cc24057 Compare April 2, 2025 19:49

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from cc24057 to 8c7d389 Compare April 2, 2025 22:51

etobella requested changes Apr 3, 2025

View reviewed changes

victoralmau suggested changes Apr 3, 2025

View reviewed changes

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch 3 times, most recently from 61e9209 to da313c8 Compare April 3, 2025 23:11

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch 2 times, most recently from 7e1e4f1 to 0296783 Compare April 4, 2025 05:23

kobros-tech changed the title ~~[16.0][IMP] sign_oca: connect sign requests with survey answers~~ [ADD] survey_sign_oca: survey and sign_oca connector Apr 4, 2025

[ADD] survey_sign_oca: survey and sign_oca connector

38ad02c

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 0296783 to 38ad02c Compare April 4, 2025 23:55

kobros-tech added 2 commits April 5, 2025 10:16

[IMP] survey_sign_oca: populate check fields from survey answers

e3aa7f4

[IMP] survey_sign_oca: populate fields in backend

41f289c

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from bdd58a7 to 41f289c Compare April 6, 2025 06:08

kobros-tech mentioned this pull request Apr 7, 2025

[FIX] sign_oca: correct syntax and handle js logic #102

Merged

[IMP] survey_sign_oca: depend on new survey signature type

23ccb8e

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from ac05641 to 4a518a0 Compare April 11, 2025 14:12

[IMP] survey_sign_oca: make start button text editable

248dbea

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 4a518a0 to 248dbea Compare April 11, 2025 14:23

victoralmau suggested changes Apr 16, 2025

View reviewed changes

victoralmau mentioned this pull request Apr 16, 2025

[IMP] survey_question_type_binary: enable sign in survey OCA/survey#157

Open

[IMP] survey_sign_oca: review changes

908ca86

kobros-tech force-pushed the 16.0-imp-sign_oca-link-survey branch from 44c8d5f to 908ca86 Compare April 21, 2025 21:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] survey_sign_oca: survey and sign_oca connector #99

[ADD] survey_sign_oca: survey and sign_oca connector #99

kobros-tech commented Apr 2, 2025 •

edited

Loading

OCA-git-bot commented Apr 2, 2025

dnplkndll commented Apr 2, 2025

kobros-tech commented Apr 2, 2025

etobella left a comment

victoralmau left a comment

kobros-tech commented Apr 3, 2025

etobella commented Apr 3, 2025 •

edited

Loading

kobros-tech commented Apr 3, 2025

kobros-tech commented Apr 3, 2025

kobros-tech commented Apr 5, 2025

kobros-tech commented Apr 6, 2025

kobros-tech commented Apr 8, 2025

victoralmau Apr 16, 2025

victoralmau Apr 16, 2025

kobros-tech Apr 16, 2025

victoralmau Apr 16, 2025

kobros-tech Apr 16, 2025

victoralmau Apr 16, 2025

kobros-tech Apr 16, 2025

victoralmau Apr 16, 2025

kobros-tech Apr 16, 2025

kobros-tech Apr 16, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

	# This field is required for the inverse of maintenance.equipment.
	# This field is required for the inverse of survey.user.input.

		"default_maintenance_equipment_id": self.id,
		"search_default_maintenance_equipment_id": self.id,

	"depends": ["sign_oca", "survey", "survey_question_type_binary"],
	"depends": ["sign_oca", "survey", "survey_question_type_binary"],

[ADD] survey_sign_oca: survey and sign_oca connector #99

Are you sure you want to change the base?

[ADD] survey_sign_oca: survey and sign_oca connector #99

Conversation

kobros-tech commented Apr 2, 2025 • edited Loading

OCA-git-bot commented Apr 2, 2025

dnplkndll commented Apr 2, 2025

kobros-tech commented Apr 2, 2025

etobella left a comment

Choose a reason for hiding this comment

victoralmau left a comment

Choose a reason for hiding this comment

kobros-tech commented Apr 3, 2025

etobella commented Apr 3, 2025 • edited Loading

kobros-tech commented Apr 3, 2025

kobros-tech commented Apr 3, 2025

kobros-tech commented Apr 5, 2025

kobros-tech commented Apr 6, 2025

kobros-tech commented Apr 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 17, 2025

kobros-tech commented Apr 2, 2025 •

edited

Loading

etobella commented Apr 3, 2025 •

edited

Loading