[17.0][MIG] mail_activity_done: Migration to 17.0 #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have been completed. fixup moment js fixup
Changed property in test to a correct one Changed README Added necessary checks if module does not have an icon Added default value to _original_module
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/es/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/it/
Currently translated at 46.6% (7 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 60.0% (9 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fi/
Currently translated at 100.0% (15 of 15 strings) Translation: social-16.0/social-16.0-mail_activity_done Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_activity_done/fr/
vvrossem
force-pushed
the
17.0-mig-mail_activity_done
branch
2 times, most recently
from
a1b6c9d
to
204921e
Compare
vvrossem
force-pushed
the
17.0-mig-mail_activity_done
branch
from
204921e
to
9a7adbd
Compare
vvrossem
force-pushed
the
17.0-mig-mail_activity_done
branch
from
9a7adbd
to
3517ac1
Compare
|
Supersedes #1346 |
yankinmax
reviewed
Jun 7, 2024
| @@ -16,7 +16,7 @@ class MailActivity(models.Model): | |||
| compute="_compute_state", | |||
| search="_search_state", | |||
| ) | |||
| date_done = fields.Date("Completed Date", index="btree", readonly=True) | |||
| date_done = fields.Date("Completed Date", index="btree") | |||
There was a problem hiding this comment.
Why are you removing readonly=True here and add it to the view?
There was a problem hiding this comment.
From the Migration to version 17.0 guidelines:
If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so avoid it as possible and define the
readonlyattribute on the views instead.
|
/ocabot migration mail_activity_done |
StefanRijnhart
approved these changes
Jun 21, 2024
yankinmax
approved these changes
Jun 21, 2024
|
@vvrossem thanks for the fixes porting! |
hbrunn
approved these changes
Jul 22, 2024
|
/ocabot merge nobump |
1 similar comment
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Jul 22, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at a8c4026. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration done from 16.0 to 17.0.
However, 16.0 doesn't contain the following fix merged in 15.0:
[15.0] [FIX] mail_activity_done: Remove broken and apparently unused js file #994
The PR [16.0][FIX] mail_activity_done: Remove broken and apparently unused js file #1386 ports it from 15.0 to 16.0.
This PR ports it from 15.0 to 17.0