Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mail_message_restrict #1395

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jun 13, 2024

Superseding of #1177

@qrtl QT3509

vals.get("model") not in subtype.allow_send_model_ids.mapped("model")
and not subtype.internal
):
raise ValidationError(
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValidationError(
raise UserError(


def test_create_message_with_comment_type_not_allowed_model(self):
# Creating a message with comment type and not allowed model
with self.assertRaises(ValidationError):
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with self.assertRaises(ValidationError):
with self.assertRaises(UserError):

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-mail_message_restrict branch 3 times, most recently from 3a89e98 to d782feb Compare June 14, 2024 01:22
Copy link
Sponsor Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants