-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] mail_message_restrict #1395
Open
AungKoKoLin1997
wants to merge
1
commit into
OCA:15.0
Choose a base branch
from
qrtl:15.0-add-mail_message_restrict
base: 15.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
15.0-add-mail_message_restrict
branch
from
June 13, 2024 10:13
5aa66bf
to
3252bff
Compare
yostashiro
suggested changes
Jun 13, 2024
vals.get("model") not in subtype.allow_send_model_ids.mapped("model") | ||
and not subtype.internal | ||
): | ||
raise ValidationError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
raise ValidationError( | |
raise UserError( |
|
||
def test_create_message_with_comment_type_not_allowed_model(self): | ||
# Creating a message with comment type and not allowed model | ||
with self.assertRaises(ValidationError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
with self.assertRaises(ValidationError): | |
with self.assertRaises(UserError): |
AungKoKoLin1997
force-pushed
the
15.0-add-mail_message_restrict
branch
3 times, most recently
from
June 14, 2024 01:22
3a89e98
to
d782feb
Compare
yostashiro
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. 👍
AungKoKoLin1997
force-pushed
the
15.0-add-mail_message_restrict
branch
from
July 31, 2024 15:31
d782feb
to
55fc3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseding of #1177
@qrtl QT3509