16.0 - Migration mail_embed_image #1402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilmanuel
approved these changes
Jun 18, 2024
| ).decode("utf-8") | ||
| image_content = response.content | ||
| filepart = MIMEImage(image_content) | ||
| filepart.add_header("Content-ID", f"<{cid}>") |
There was a problem hiding this comment.
ask : shall not be the cid.encode("utf-8") ?
imlopes
force-pushed
the
16.0-mig-mail_embed_image
branch
from
b7b8a38
to
8fcc1b9
Compare
gurneyalex
approved these changes
Jun 18, 2024
|
This PR has the |
hbrunn
requested changes
Jul 5, 2024
| src = img.get("src") | ||
| if src and not src.startswith("data:") and not src.startswith("base64:"): | ||
| try: | ||
| response = requests.get(src, timeout=10) |
There was a problem hiding this comment.
the reason the original did the fetching in a somewhat roundabout way is that what you do here allows malicious users to craft emails to themselves and have Odoo fetch arbitrary resources from the internal network. Can be harmless, can be catastrophic depending on what's accessible from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.