[14.0][IMP] mail_restrict_follower_selection: allow to use ref in domain #1405
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this is change it is now possible to use the `ref` function in the domain set in a parameter, allowing to include xmlids in the domain.
| @@ -20,7 +20,7 @@ def _message_add_suggested_recipient( | |||
| domain = self.env[ | |||
| "mail.wizard.invite" | |||
| ]._mail_restrict_follower_selection_get_domain() | |||
| eval_domain = safe_eval(domain) | |||
| eval_domain = safe_eval(domain, locals_dict={"ref": self.env.ref}) | |||
There was a problem hiding this comment.
It's probably safer to use a version of ref that returns the id rather than the browse record, like Odoo does when interpreting XML data: https://github.com/odoo/odoo/blob/14.0/odoo/tools/convert.py#L62. That way there is no vector in which an attacker can call methods on a record from a domain.
There was a problem hiding this comment.
Thanks for the review @StefanRijnhart, good point.
I updated the PR.
| Returning only the ID of the record. | ||
|
|
||
| """ | ||
| return env.ref(id_str, raise_if_not_found).id |
There was a problem hiding this comment.
This is not going to work if not found, even without raising:
>>> env.ref("not.exists", False).id
Traceback (most recent call last):
File "<console>", line 1, in <module>
AttributeError: 'NoneType' object has no attribute 'id'
Your simplest option might be to just drop raise_if_not_found from the method signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this is change it is now possible to use the
reffunction in the domain set in a parameter, allowing to include xmlids in the domain.