[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots #34

chrisandrewmann · 2024-06-03T21:37:25Z

Currently there is no way to delete pivots or lists in the GUI after creation. Pivots are also created with name "undefined".

I added a button and relevant methods to delete, but couldn't find a way to programmatically close the sidepanel without causing it to crash due to OWL lifecycle error, when using closeSidePanel()
Only solution I found was to force the "filter" sidebar to load in place after deletion of pivot /list using: this.env.openSidePanel("FilterPanel", {});
Otherwise it works, but maybe someone with more OWL knowledge can improve.
Also added a name for newly created pivots, using the title.

Comments welcome.

Future note: I noticed that community is missing a way to rename Pivots, something Enterprise has. Maybe good for future?

pedrobaeza · 2024-06-24T13:26:00Z

Please rebase instead of doing pull for avoiding merge commits here in the PR.

pedrobaeza · 2024-06-24T15:47:19Z

Is this ready to be reviewed?

chrisandrewmann · 2024-06-24T15:52:10Z

Yes it is.

pedrobaeza · 2024-06-24T18:15:55Z

Trying on runboat, I get this error trying to add a pivot to an spreadsheet:

OwlError: The following error occurred in onWillStart: "subTreeKeys.forEach is not a function"
    OwlError@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:16490:5 (/web/static/lib/owl/owl.js:87)
    wrapError@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:19008:23 (/web/static/lib/owl/owl.js:2605)
    onWillStart@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:19051:29 (/web/static/lib/owl/owl.js:2648)
    setup@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:53565:20 (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_renderer.esm.js:92)
    ComponentNode@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18760:28 (/web/static/lib/owl/owl.js:2357)
    createComponent/<@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:22172:28 (/web/static/lib/owl/owl.js:5769)
    template@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js line 21943 > Function:16:21 (/web/static/lib/owl/owl.js:5540)
    _render@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18125:38 (/web/static/lib/owl/owl.js:1722)
    render@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18117:18 (/web/static/lib/owl/owl.js:1714)
    initiateRender@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18782:23 (/web/static/lib/owl/owl.js:2379)

Caused by: TypeError: subTreeKeys.forEach is not a function
    _getSpreadsheetRows@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:51191:21 (/spreadsheet/static/src/pivot/pivot_model.js:589)
    getTableStructure@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:50983:27 (/spreadsheet/static/src/pivot/pivot_model.js:381)
    getTableStructure@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:50234:28 (/spreadsheet/static/src/pivot/pivot_data_source.js:121)
    importDataPivot@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:53871:51 (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_action.esm.js:196)

chrisandrewmann · 2024-06-24T19:06:07Z

Trying on runboat, I get this error trying to add a pivot to an spreadsheet:

OwlError: The following error occurred in onWillStart: "subTreeKeys.forEach is not a function"
    OwlError@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:16490:5 (/web/static/lib/owl/owl.js:87)
    wrapError@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:19008:23 (/web/static/lib/owl/owl.js:2605)
    onWillStart@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:19051:29 (/web/static/lib/owl/owl.js:2648)
    setup@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:53565:20 (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_renderer.esm.js:92)
    ComponentNode@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18760:28 (/web/static/lib/owl/owl.js:2357)
    createComponent/<@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:22172:28 (/web/static/lib/owl/owl.js:5769)
    template@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js line 21943 > Function:16:21 (/web/static/lib/owl/owl.js:5540)
    _render@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18125:38 (/web/static/lib/owl/owl.js:1722)
    render@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18117:18 (/web/static/lib/owl/owl.js:1714)
    initiateRender@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/web.assets_common.js:18782:23 (/web/static/lib/owl/owl.js:2379)

Caused by: TypeError: subTreeKeys.forEach is not a function
    _getSpreadsheetRows@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:51191:21 (/spreadsheet/static/src/pivot/pivot_model.js:589)
    getTableStructure@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:50983:27 (/spreadsheet/static/src/pivot/pivot_model.js:381)
    getTableStructure@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:50234:28 (/spreadsheet/static/src/pivot/pivot_data_source.js:121)
    importDataPivot@http://oca-spreadsheet-16-0-pr34-0671a140d9e4.runboat.odoo-community.org/web/assets/debug/spreadsheet.o_spreadsheet.js:53871:51 (/spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_action.esm.js:196)

Strange, just tried it and can't reproduce on Runboat. Maybe try again and clear cache as I rebased and force pushed

pedrobaeza

It seems a problem of my Firefox browser. Trying on Chrome, it's working. Tried the new option. It works, although the cells get with #ERROR after deleting the pivot. Shouldn't they be emptied?

chrisandrewmann · 2024-06-25T07:56:22Z

@pedrobaeza
OK I'll test in Firefox too.
Regards deleting the cells, I'm not sure how to but figured it's not bad to leave them in place for manual deletion as it behaves the same as enterprise when deleting.

chrisandrewmann · 2024-06-25T10:27:41Z

Have tested in Firefox locally with no issues. Just rebased again as automated translations meant it was behind again.

Also i've made a small amendment by setting the Pivot name, otherwise it was "Undefined" which makes no sense as it's hard to identify them apart.

When adding a pivot table to a spreadsheet, it does not maintain the specified order because the sortedColumn option is not being completed. Steps to reproduce the issue: 1. Go to a pivot table 2. Change the default order 3. Add to the spreadsheet The added table will not have preserved the order.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

…ture order of fields

The error is happening because the dashboard where the data has to be added is not being showed. With this changes the field to define the dashboard is required and is showed. Added a way to limit the search to the dashboards that can be edited

On dashboards exists tables that are updated dynamically, with this changes we have the option to generate this dynamic tables using the pivot inserter. Added a button to duplicate and change to dynamic table the selected table on spreadsheet editor. If a table with multiple row goups generated, the way to generate the dynamic table will be set the number of rows for each level of indentation. Example: 2 rowGroupBys 3 number of rows - val1 - subval1.1 - subval1.2 - subval1.3 - val2 - subval2.1 - subval2.2 - subval2.3 - val3 - subval3.1 - subval3.2 - subval3.3

Since this changes the field datasource_name does not work with tree and graph. Now the datasource_name is set as data name for the created data. Furthermore, the capability to create dynamic tables has no sense on tree and graph, so it has been limited for pivots.

Currently translated at 100.0% (16 of 16 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_dashboard_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_dashboard_oca/it/

Currently translated at 100.0% (95 of 95 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

Currently translated at 100.0% (16 of 16 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_dashboard_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_dashboard_oca/pt/

Currently translated at 100.0% (95 of 95 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/pt/

translation terms

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

With these changes, we have added the ability to make the columns dynamic, just as is done with the rows. To add this type of table, we will need to select the dynamic columns option and choose the number of columns to insert. Keep in mind that if multiple column levels are selected, the chosen number will apply to each of these levels. In addition to this, the wizard that opens with the spreadsheet button has been updated to allow us to choose the type of dynamism we expect in the inserted table.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Currently translated at 100.0% (99 of 99 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

Currently translated at 63.6% (63 of 99 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/fr/

If any module males a primary template from the ones where the button is added, the button wasn't be shown previously. That's because the inheritance and load order works in OWL. The way to fix this is to make this load order deterministic specifying to be loaded after the corresponding template for being taken into account for primary views. This also required to split the templates file into several ones.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Steps to reproduce the error: 1. Go to a pivot 2. Remove all groups of columns to set only the measure 3. Add the pivot to a spreadsheet with dynamic columns and a number of columns An error will be thrown

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Currently translated at 100.0% (101 of 101 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

pedrobaeza · 2024-09-25T16:49:13Z

Incorrect rebasing it seems

chrisandrewmann force-pushed the 16.0 branch from d7443fd to fb1d611 Compare June 3, 2024 21:43

chrisandrewmann mentioned this pull request Jun 6, 2024

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button #35

Closed

chrisandrewmann force-pushed the 16.0 branch 2 times, most recently from fb1d611 to 0671a14 Compare June 24, 2024 14:38

pedrobaeza added this to the 16.0 milestone Jun 24, 2024

pedrobaeza reviewed Jun 25, 2024

View reviewed changes

pedrobaeza requested a review from etobella June 25, 2024 07:30

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button

aea8012

chrisandrewmann force-pushed the 16.0 branch from 0671a14 to aea8012 Compare June 25, 2024 10:26

[IMP] Set name on newly created Pivots

a9524e8

chrisandrewmann changed the title ~~[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button~~ [IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots Jun 25, 2024

CarlosRoca13 and others added 12 commits September 25, 2024 14:59

[UPD] Update spreadsheet_oca.pot

f16caf7

[BOT] post-merge updates

496e496

Update translation files

370c25a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

[IMP] spreadsheet*_oca: Add field to define name of table and restruc…

8490278

…ture order of fields

[IMP] spreadsheet_oca: Allow download spreadsheet as XLSX

c5a7796

[IMP] spreadsheet_dashboard_oca: Add option to create new dashboard

a5435c4

[UPD] Update spreadsheet_dashboard_oca.pot

997347c

[UPD] Update spreadsheet_oca.pot

fe0b3b9

mymage and others added 28 commits September 25, 2024 15:00

Translated using Weblate (Italian)

1e291e1

Currently translated at 100.0% (16 of 16 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_dashboard_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_dashboard_oca/it/

Translated using Weblate (Italian)

9916f55

Currently translated at 100.0% (95 of 95 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

Added translation using Weblate (Portuguese)

d9cbf62

Added translation using Weblate (Portuguese)

3ae1297

Translated using Weblate (Portuguese)

95fd9e8

Currently translated at 100.0% (95 of 95 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/pt/

[FIX] spreadsheet_oca: correct spelling errors and remove outdated

c5d060b

translation terms

[UPD] Update spreadsheet_oca.pot

2ea7897

[BOT] post-merge updates

b362bc6

Update translation files

03a2b5f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

[UPD] Update spreadsheet_oca.pot

fc6fb65

[BOT] post-merge updates

ddb16a8

Update translation files

e592a83

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Translated using Weblate (Italian)

3e7c197

Currently translated at 100.0% (99 of 99 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

Added translation using Weblate (French)

cbadf88

Translated using Weblate (French)

bd243dd

Currently translated at 63.6% (63 of 99 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/fr/

[UPD] Update spreadsheet_oca.pot

577d555

[BOT] post-merge updates

e367fe4

Update translation files

2600435

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

[FIX] spreadsheet_oca: Avoid to show dynamic cols when no cols selected

b025b81

Steps to reproduce the error: 1. Go to a pivot 2. Remove all groups of columns to set only the measure 3. Add the pivot to a spreadsheet with dynamic columns and a number of columns An error will be thrown

[UPD] Update spreadsheet_oca.pot

9bb06ed

[BOT] post-merge updates

9def6e6

Update translation files

dc4c605

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/

Translated using Weblate (Italian)

815ab6f

Currently translated at 100.0% (101 of 101 strings) Translation: spreadsheet-16.0/spreadsheet-16.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-16-0/spreadsheet-16-0-spreadsheet_oca/it/

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button

302b642

[IMP] Set name on newly created Pivots

1f88552

chrisandrewmann closed this Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots #34

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots #34

chrisandrewmann commented Jun 3, 2024 •

edited

Loading

pedrobaeza commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

chrisandrewmann commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

chrisandrewmann commented Jun 24, 2024

pedrobaeza left a comment

chrisandrewmann commented Jun 25, 2024 •

edited

Loading

chrisandrewmann commented Jun 25, 2024 •

edited

Loading

pedrobaeza commented Sep 25, 2024

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots #34

[IMP] spreadsheet_oca: Add ability to delete pivots and lists via button, set name on new pivots #34

Conversation

chrisandrewmann commented Jun 3, 2024 • edited Loading

pedrobaeza commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

chrisandrewmann commented Jun 24, 2024

pedrobaeza commented Jun 24, 2024

chrisandrewmann commented Jun 24, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

chrisandrewmann commented Jun 25, 2024 • edited Loading

chrisandrewmann commented Jun 25, 2024 • edited Loading

pedrobaeza commented Sep 25, 2024

chrisandrewmann commented Jun 3, 2024 •

edited

Loading

chrisandrewmann commented Jun 25, 2024 •

edited

Loading

chrisandrewmann commented Jun 25, 2024 •

edited

Loading