-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP+FIX] spreadsheet*_oca: New field to name the pivot table and fixed error adding to new sheet of dashboard #38
[16.0][IMP+FIX] spreadsheet*_oca: New field to name the pivot table and fixed error adding to new sheet of dashboard #38
Conversation
…ture order of fields
The error is happening because the dashboard where the data has to be added is not being showed. With this changes the field to define the dashboard is required and is showed. Added a way to limit the search to the dashboards that can be edited
The XLSX data is generated by the core module. If you check the behavior in the odoo enterprise module, you will see that the result is the same. For other comments I will do the changes, thanks :) |
@carolinafernandez-tecnativa changes done 😄 The value of Datasource Name is the name that will be filled to identify the table on the spreadsheet. |
no_edit_ids = ( | ||
self.env["ir.model.data"] | ||
.search( | ||
[ | ||
("model", "=", self._name), | ||
("module", "!=", "__export__"), | ||
("noupdate", "=", 0), | ||
] | ||
) | ||
.mapped("res_id") | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a brand new dashboard but I can't make it to show up in the wizard. Am I doing something wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to add a spreadsheet to the panel to be able to show it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I can't select any dashboard in the wizard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to dashboard new sheet. I was expecting to let me choose a dashboard to wich apend a sheet. Did I understand it wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that option that you say can be set, I will see how to add it
Thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. See? I was getting it wrong 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new option to create new dashboards 😄
On dashboards exists tables that are updated dynamically, with this changes we have the option to generate this dynamic tables using the pivot inserter. Added a button to duplicate and change to dynamic table the selected table on spreadsheet editor. If a table with multiple row goups generated, the way to generate the dynamic table will be set the number of rows for each level of indentation. Example: 2 rowGroupBys 3 number of rows - val1 - subval1.1 - subval1.2 - subval1.3 - val2 - subval2.1 - subval2.2 - subval2.3 - val3 - subval3.1 - subval3.2 - subval3.3
c189796
to
396e2b5
Compare
Since this changes the field datasource_name does not work with tree and graph. Now the datasource_name is set as data name for the created data. Furthermore, the capability to create dynamic tables has no sense on tree and graph, so it has been limited for pivots.
396e2b5
to
5a3292d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working.
Thanks for all the fixes and the new excellent features!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have in mind to start the migration to 17.0, if you merge this PR we could use it as a starting point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review LGTM :) Thanks!
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 0b498fc. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnaiva TT50012 and TT50206
ping @pedrobaeza @chienandalu