Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] spreadsheet_*_oca: Add possibility to make columns dynamic #44

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

CarlosRoca13
Copy link
Contributor

With these changes, we have added the ability to make the columns dynamic, just as is done with the rows.

To add this type of table, we will need to select the dynamic columns option and choose the number of columns to insert. Keep in mind that if multiple column levels are selected, the chosen number will apply to each of these levels.

In addition to this, the wizard that opens with the spreadsheet button has been updated to allow us to choose the type of dynamism we expect in the inserted table.

Example of use:
example

TT50606

ping @pedrobaeza @chienandalu

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 3, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little detail:

image

With these changes, we have added the ability to make the columns
dynamic, just as is done with the rows.

To add this type of table, we will need to select the dynamic columns
option and choose the number of columns to insert. Keep in mind that if
multiple column levels are selected, the chosen number will apply to
each of these levels.

In addition to this, the wizard that opens with the spreadsheet button
has been updated to allow us to choose the type of dynamism we expect in
the inserted table.
@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-IMP-spreadsheet_oca-dyn-col branch from 78b4626 to a864da7 Compare September 4, 2024 05:55
@CarlosRoca13
Copy link
Contributor Author

Change done

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional 👍

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-44-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 4, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-44-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-44-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c5014b6 into OCA:16.0 Sep 4, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b7e90ae. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-IMP-spreadsheet_oca-dyn-col branch September 4, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants