[16.0][FIX] spreadsheet_oca: Show the "Add" button in invoice list #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosRoca13
changed the title
CarlosRoca13
force-pushed
the
16.0-IMP-spreadsheet_oca-assets
branch
from
472cf22 to
b0847b4
Compare
|
Tested an working. The only comment is about the commit message. It's a FIX instead of an IMP, as there's something not working, and the first line should express what is fixing: |
If any module males a primary template from the ones where the button is added, the button wasn't be shown previously. That's because the inheritance and load order works in OWL. The way to fix this is to make this load order deterministic specifying to be loaded after the corresponding template for being taken into account for primary views. This also required to split the templates file into several ones.
CarlosRoca13
force-pushed
the
16.0-IMP-spreadsheet_oca-assets
branch
from
b0847b4 to
bf32eda
Compare
CarlosRoca13
changed the title
|
Change done @pedrobaeza |
pedrobaeza
approved these changes
Sep 17, 2024
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at ac4980b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this files aren't charged just after the main file if some module that is charged before spreadsheet_oca makes a primary template, the button will not be shown.
Exmple:
cc @Tecnativa TT50815
ping @pedrobaeza @chienandalu